Conversation
* Require PHP 7.1 minimum * Upgrade PHPUnit * Remove old versions of PHP from Travis
…tiate from JSON data Create base test case for tests to inherit from so that there's easy access to fixtures
…erit from base TestCase
…ional factory methods
…more appropriate place to encapsulate instantiation. The same with forms. Use static factory method instead of putting all the logic in the Api class
… class * Introduce namespaced exceptions * Add test case for Ref and be a bit stricter about parsing refs in the factory method * Fix doc block for Form constructor and make the constructor private
\Prismic\Api::get() simplified and hoisted up next to the constructor
…cs check, fix and tests
…nd write a test for it
…client and cache instead of the Api. This will allow for easier testing and is the only reason the Api instance is injected in the first place. Extract duplicated code in various Api methods into a private method for preparing query options
…gs make sense and add tests
…doesn't support v7.x
…Cache. Wrap Guzzle client exceptions
…ieval of the api data in a try/catch
…eption so that it does not assume a response will be present
…to the samples/ directory
WIP - PHP >=7.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.