fix: only send unknown or intentionally tracked errors to Segment#136
Merged
angeloashmore merged 2 commits intomainfrom Apr 15, 2026
Merged
fix: only send unknown or intentionally tracked errors to Segment#136angeloashmore merged 2 commits intomainfrom
angeloashmore merged 2 commits intomainfrom
Conversation
Resolves #131 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Known errors get `success: false` without an error message. Auth errors and NoSupportedFrameworkError include the error message for product signal. Unknown errors include the error message and are also sent to Sentry. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5b214b3. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves: #131
Description
Previously, all errors were sent to Segment before being classified. Known/expected errors (user input mistakes, auth failures, missing config) added noise to analytics. Now only unknown errors and
NoSupportedFrameworkErrorare tracked.Checklist
Preview
How to QA 1
Note
Low Risk
Small change to telemetry/error-reporting behavior in the CLI; main risk is reduced visibility or altered analytics for some known error cases.
Overview
Adjusts CLI error handling in
src/index.tsso Segment telemetry only includeserrordetails for unexpected failures (andNoSupportedFrameworkError), while other known/expected errors end the event without an error payload.This reorders the
catchbranches to classifyCommandErrorearlier and avoids attaching error metadata for common user-facing failures (e.g., missing/invalid config, not-found), while still reporting unknown errors to both Segment and Sentry.Reviewed by Cursor Bugbot for commit 5b214b3. Bugbot is set up for automated code reviews on this repo. Configure here.
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩