Skip to content

fix: rename stray segmentTrackEnd call to trackCommandEnd#177

Merged
angeloashmore merged 1 commit intomainfrom
aa/fix-amplitude-type-error
May 5, 2026
Merged

fix: rename stray segmentTrackEnd call to trackCommandEnd#177
angeloashmore merged 1 commit intomainfrom
aa/fix-amplitude-type-error

Conversation

@angeloashmore
Copy link
Copy Markdown
Member

@angeloashmore angeloashmore commented May 5, 2026

Resolves:

Description

A leftover reference to the pre-refactor segmentTrackEnd was missed in #174. This renames it to trackCommandEnd so the file type-checks again.

Checklist

  • A comprehensive Linear ticket, providing sufficient context and details to facilitate the review of the PR, is linked to the PR.
  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

How to QA 1


View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

Note

Low Risk
Low risk: a one-line rename to call the correct tracking helper; behavior should match other error paths and primarily fixes TypeScript/type-checking.

Overview
Fixes the UnknownRequestError handler in src/index.ts to call trackCommandEnd (instead of the leftover segmentTrackEnd) when recording failed commands, aligning error tracking with the post-refactor API and restoring type-checking.

Reviewed by Cursor Bugbot for commit bc64453. Bugbot is set up for automated code reviews on this repo. Configure here.

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@angeloashmore angeloashmore merged commit 90818aa into main May 5, 2026
13 checks passed
@angeloashmore angeloashmore deleted the aa/fix-amplitude-type-error branch May 5, 2026 18:33
@github-actions github-actions Bot mentioned this pull request May 5, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant