fix: rename stray segmentTrackEnd call to trackCommandEnd#177
Merged
angeloashmore merged 1 commit intomainfrom May 5, 2026
Merged
fix: rename stray segmentTrackEnd call to trackCommandEnd#177angeloashmore merged 1 commit intomainfrom
angeloashmore merged 1 commit intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves:
Description
A leftover reference to the pre-refactor
segmentTrackEndwas missed in #174. This renames it totrackCommandEndso the file type-checks again.Checklist
Preview
How to QA 1
Need help on this PR? Tag
@codesmithwith what you need.Note
Low Risk
Low risk: a one-line rename to call the correct tracking helper; behavior should match other error paths and primarily fixes TypeScript/type-checking.
Overview
Fixes the
UnknownRequestErrorhandler insrc/index.tsto calltrackCommandEnd(instead of the leftoversegmentTrackEnd) when recording failed commands, aligning error tracking with the post-refactor API and restoring type-checking.Reviewed by Cursor Bugbot for commit bc64453. Bugbot is set up for automated code reviews on this repo. Configure here.
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩