Merged
Conversation
angeloashmore
force-pushed
the
feat/webhook-commands
branch
from
c0da499 to
21b0a37
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Add commands to manage webhooks in a Prismic repository: create, list, view, remove, test, enable, disable, status, add-header, remove-header, and set-triggers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
angeloashmore
force-pushed
the
feat/webhook-commands
branch
from
21b0a37 to
e29c315
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Align webhook files with main's module structure: - auth: ./lib/auth → ../auth - config: ./lib/config (safeGetRepositoryFromConfig) → ../project (safeGetRepositoryName) - env: ../lib/env → ../env - valibot → zod/mini Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Each trigger field was incorrectly reading from webhookConfig.documentsUnpublished instead of the corresponding property. The last line also used a duplicate "documentsPublished" key instead of "tagsDeleted". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…rectly Remove the TRIGGER_DISPLAY mapping and reverse-lookup logic. Trigger names now use the API's camelCase format (e.g. documentsPublished) everywhere, eliminating unnecessary format conversion. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove test, status, add-header, and remove-header webhook subcommands that are not needed for the initial release. Tighten host parameter types from `string | undefined` to `string` in wroom client functions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| await writeFile( | ||
| new URL(".prismic", home), | ||
| JSON.stringify({ token, host: DEFUALT_PRISMIC_HOST }), | ||
| ); |
There was a problem hiding this comment.
Login fixture ignores PRISMIC_HOST environment variable
Medium Severity
The login fixture now hardcodes DEFUALT_PRISMIC_HOST ("prismic.io") into the .prismic auth file, instead of using the process.env.PRISMIC_HOST value. Previously the module-level PRISMIC_HOST variable respected the environment variable. The new host fixture correctly reads from the env, but login doesn't use it — so when PRISMIC_HOST is set to a custom value, the CLI under test reads the wrong host from its auth file, while test helpers (like getWebhooks in test/prismic.ts) use the correct one.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #52
Description
Add webhook management commands to the CLI. This introduces the
prismic webhookcommand with subcommands for creating, listing, viewing, removing, enabling, and disabling webhooks, as well as managing triggers.The following commands are included:
prismic webhook listprismic webhook viewprismic webhook createprismic webhook removeprismic webhook set-triggersprismic webhook enableprismic webhook disableChecklist
Preview
How to QA 1
Build and run
./dist/index.mjs webhookto see the help output.Note
Medium Risk
Adds new CLI subcommands that mutate repository webhook configuration via authenticated requests to Prismic settings endpoints, which could impact users’ webhook setups if request formatting/trigger selection is wrong. Changes are mostly additive and covered by new e2e tests, but touch live remote state (create/update/delete).
Overview
Adds a new
prismic webhooktop-level command with subcommands to list/view/create/remove webhooks, enable/disable them, and update trigger events (with trigger validation and helpful error handling).Introduces a
wroomclient (getWebhooks,createWebhook,updateWebhook,deleteWebhook) that talks to Prismic’s webhooks settings endpoints using the existingrequesthelper and zod schemas.Updates tests to cover the new webhook workflows end-to-end and tweaks help-text assertions and test fixtures to pass through a configurable
PRISMIC_HOST.Written by Cursor Bugbot for commit 91f12f8. This will update automatically on new commits. Configure here.
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩