Refactored variableAttributeLoader#303
Merged
landinjm merged 14 commits intoprisms-center:masterfrom Nov 21, 2024
Merged
Conversation
fractalsbyx
force-pushed
the
VAL-refactor
branch
from
edf5c8a to
9fcb873
Compare
landinjm
requested changes
Nov 20, 2024
Contributor
landinjm
left a comment
landinjm
left a comment
There was a problem hiding this comment.
Please add doxygen style comments to variableAttributeLoader.h and variableAttributes.h
compiles, runs cahnHilliard 11-12
…leAttributeLoader
landinjm
force-pushed
the
VAL-refactor
branch
from
1429ee8 to
eedc2b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, for every variable attribute, several copies of vectors of information were used in several places in the code. Now, attributes are stored in a single map that maps the field index to an attributes instance. In several places in the code, fields were looped by index, using the size of various different vectors, or the number of fields. Now, in most places, we loop by value. With a little more work, we can remove the requirement for field numbers to be concurrent and start at 0.
Known issues:
Need some checks in place to make sure that the user inputs are well-formatted (no two fields with the same name, 'change()' dependencies correct, dependencies make sense, etc).
Some unit tests became deprecated. May want replacements.
Not well-tested yet
Certain simplifications may be possible (postprocess fields may not need to be treated so differently, others...)
Closes #281 ?