Updating CMakeLists.txt#315
Merged
landinjm merged 14 commits intoprisms-center:masterfrom Nov 19, 2024
Merged
Conversation
Contributor
Author
|
Closes #296 |
Contributor
Author
|
Note that this does change the behavior in how executable files are generated. Before, you would run make release or make debug to generate |
Contributor
Author
|
Partially addresses #314 |
fractalsbyx
reviewed
Nov 19, 2024
fractalsbyx
approved these changes
Nov 19, 2024
Contributor
fractalsbyx
left a comment
fractalsbyx
left a comment
There was a problem hiding this comment.
wow, so much better!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the
CMakeLists.txtto be more understandable and modular.I've adapted the one used by ASPECT which is much more helpful in terms of error handling. For example, it will warn if the dependencies are not installed or if there is a leftover
CMakeCache.txtThis PR also adds Catch2 for unit testing in
catch.hpp