Skip to content

Old Prisms Eshelby App Updates#556

Merged
landinjm merged 6 commits intoprisms-center:masterfrom
john-mcki:main
Jul 3, 2025
Merged

Old Prisms Eshelby App Updates#556
landinjm merged 6 commits intoprisms-center:masterfrom
john-mcki:main

Conversation

@john-mcki
Copy link
Copy Markdown
Contributor

@john-mcki john-mcki commented May 20, 2025

Description

Old Eshelby Application Update. Note, history is slightly messed up.

Checklist

Miscellaneous items that may need to be done when making a PR:

  • Documentation related to this PR is up to date (Doxygen format)
  • Unit test(s)
  • Code is properly formatted
  • Application update script is up to date
  • PR labels are applied
  • Issues are linked

@fractalsbyx
Copy link
Copy Markdown
Contributor

Could you summarize the changes in the PR description

@john-mcki
Copy link
Copy Markdown
Contributor Author

Some specifics on the changes:

  • in equations.cc: added distance as a calculated double, added a variable to track inclusion radius (may be redundant, as its a variable in parameters.prm), adjusted sfts to use tanh instead of the exponential identity of tanh
  • in IC's and BC's added a for loop to calculate the boundary conditions (for loop calculations based on analytical solution)
  • in customPDE added lines to read new variables I added to parameters.prm

@fractalsbyx fractalsbyx self-requested a review May 20, 2025 21:03
@fractalsbyx fractalsbyx marked this pull request as ready for review May 20, 2025 21:08
Comment thread applications/eshelbyInclusion/equations.cc Outdated
Comment thread applications/eshelbyInclusion/parameters.prm Outdated
Comment thread applications/eshelbyInclusion/parameters.prm Outdated
Comment thread applications/eshelbyInclusion/equations.cc Outdated
Comment thread applications/eshelbyInclusion/ICs_and_BCs.cc
Copy link
Copy Markdown
Contributor

@landinjm landinjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@landinjm landinjm merged commit cac6975 into prisms-center:master Jul 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants