Export GLOBAL_NAMESERVERS_YAML consistently across all return paths#79
Merged
EdGeraghty merged 3 commits intocustom-nameserversfrom Apr 15, 2026
Merged
Export GLOBAL_NAMESERVERS_YAML consistently across all return paths#79EdGeraghty merged 3 commits intocustom-nameserversfrom
GLOBAL_NAMESERVERS_YAML consistently across all return paths#79EdGeraghty merged 3 commits intocustom-nameserversfrom
Conversation
Merged
Agent-Logs-Url: https://github.com/privacyint/docker-headscale/sessions/a1109ee5-2afa-49fa-ad6b-4d3d5da3ba71 Co-authored-by: EdGeraghty <20861699+EdGeraghty@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Addressing feedback on custom nameservers implementation
Export Apr 15, 2026
GLOBAL_NAMESERVERS_YAML consistently across all return paths
🆕 New Headscale Config Options+ - 2606``` |
🆕 New Headscale Config Options+ - 2606``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stacked PR addresses review feedback on the custom nameservers implementation in
container-entrypoint.sh.The issue was inconsistent export behaviour:
GLOBAL_NAMESERVERS_YAMLwas exported only in the non-empty path, but not in early-return empty paths.What changed
build_global_nameservers_yaml()to exportGLOBAL_NAMESERVERS_YAMLin both empty-list branches:ns_arrayis emptyitemsis emptyBehavioural impact
GLOBAL_NAMESERVERS_YAMLis now exported uniformly regardless of whether nameservers are present, absent, or filtered out.Code snippet