docs(azure): replace exported STORAGE_ACCOUNT_KEY with inline command substitution#89
Merged
Merged
Conversation
…tion The guide previously exported the storage account key into the shell environment in three places (Step 2, Step 6 blob creation, Step 6 Option A). Exported variables are visible via `env`, crash dumps, and shell-history tooling, all of which are undesirable for a high-value secret. All three occurrences are now rewritten to use inline command substitution directly on the `az` argument, so the key value is never placed in a named shell variable at all. Agent-Logs-Url: https://github.com/privacyint/docker-headscale/sessions/4e335591-6a37-479b-a7a5-b099b3ac96b0 Co-authored-by: EdGeraghty <20861699+EdGeraghty@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on Azure implementation and documentation updates
docs(azure): replace exported STORAGE_ACCOUNT_KEY with inline command substitution
May 1, 2026
EdGeraghty
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Azure Container Apps guide exported
STORAGE_ACCOUNT_KEYinto the shell environment, making the storage account key visible viaenv, crash dumps, and shell-history tooling across the entire session.Changes
export STORAGE_ACCOUNT_KEY=$(…)assignment; key is now inlined directly into--azure-file-account-key"$STORAGE_ACCOUNT_KEY"with inline substitution on--account-key"$STORAGE_ACCOUNT_KEY"with inline substitution on--secretsThe variable
STORAGE_ACCOUNT_KEYno longer appears anywhere in the guide.