fix: fail-fast Azure abs:// auth validation in container entrypoint#92
Merged
Conversation
…principal, or managed identity signal Agent-Logs-Url: https://github.com/privacyint/docker-headscale/sessions/b2256f84-bda2-4e8e-8c0f-0caa36d534bc Co-authored-by: EdGeraghty <20861699+EdGeraghty@users.noreply.github.com>
Agent-Logs-Url: https://github.com/privacyint/docker-headscale/sessions/b2256f84-bda2-4e8e-8c0f-0caa36d534bc Co-authored-by: EdGeraghty <20861699+EdGeraghty@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on Azure implementation and documentation updates
fix: fail-fast Azure abs:// auth validation in container entrypoint
May 1, 2026
EdGeraghty
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
abs://branch incheck_litestream_replica_urlonly caught partial service-principal credentials but never failed when no auth mechanism was configured — a misconfigured deployment would pass entrypoint validation and crash when Litestream started.Changes
Explicit three-path enforcement in the
ABS://*)case — restructured from a single partial-SP guard into an if/elif/else chain:LITESTREAM_AZURE_ACCOUNT_KEYsetAZURE_CLIENT_*var setIDENTITY_ENDPOINTorMSI_ENDPOINTpresentlog_errorto terminateReadable error output — the no-auth case emits
log_warnhint lines enumerating all three options before the terminallog_error, instead of a single unwieldy message.