This repository was archived by the owner on Apr 3, 2024. It is now read-only.
Adds Issue and PR Templates#10
Merged
Merged
Conversation
danielrose7
force-pushed
the
add-templates
branch
from
38f7b3b to
0c12dcd
Compare
Contributor
|
The correct gem-fu would be to update the appropriate version place, only when actually releasing a new gem version. Which by the way, do we have access to push a new gem version to RubyGems.org? |
Contributor
|
I think it also a good idea to add a changelog to track all behavioral changes and add that to the PR checklist. |
toddsiegel
reviewed
Feb 13, 2018
|
|
||
| ### Steps to reproduce | ||
|
|
||
| [Please give a walkthrough of the steps that got you to the problem. Include a link to a public repo, a code sample, or--even better--a failing test!] |
Contributor
There was a problem hiding this comment.
Asking for a gist might be a nice idea, but might also discourage issue submissions.
danielrose7
force-pushed
the
add-templates
branch
from
0c12dcd to
9cea308
Compare
Adding these GitHub templates so that the issues and PRs of the future are more consistent moving forward and include the bare necessities
danielrose7
force-pushed
the
add-templates
branch
from
9cea308 to
1a13554
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue does this address?
#11
What does this PR do?
Adds GitHub templates so that the issues and PRs of the future are more consistent and include the bare necessities
How do I manually test this?
No need!
Additional Comments
I bumped the gem version one patch version here as there is no functional change. @toddsiegel Is that correct gem fu?GIF for how this PR makes me feel