Adds TravisCI and tests current Ruby versions#12
Conversation
| @@ -1 +1 @@ | |||
| 2.2.6 | |||
| 2.3.6 | |||
There was a problem hiding this comment.
i'd say remove this altogether.
There was a problem hiding this comment.
I am fine with that. Seems more of a pain than anything.
| spec.authors = ['Jeremy Zornow'] | ||
| spec.email = ['jeremy@zornow.com'] | ||
| spec.required_ruby_version = '>= 1.9.3' | ||
| spec.required_ruby_version = '>= 2.2.6' |
There was a problem hiding this comment.
Any reason though not to support the whole 2.2.0 line? More generally, what should be our general support policy? I'd say any currently supported Rubies.
There was a problem hiding this comment.
I don't think there is a reason to not do the whole 2.2 line.
I picked 2.2.6 as that was the last ruby_version that jz had in here. I bumped from 1.9.3 only so bundle would run in CI (pry-byebug wanted 2+)
I agree with "any currently supported Rubies" which would mean we'd be at 2.2.9 as the lowest current. Right?
There was a problem hiding this comment.
Yeah, for another month and half, or as long as we still have an app using it. 😉
This commit ensures that TravisCI runs in an open manner with each build that is pushed to privateprep/intacct_ruby This includes a simple .travis.yml file that runs spec in all currently maintained versions of ruby. I also added the travis gem as a dev dependency and made sure these dependencies are in ABC order. You may notice that support is removed for Ruby 1.9.3. I chose to remove support because the specified version of pry-byebug requires ruby v2+. I think this gem would otherwise work with 1.9.3 but don't think we need to ensure function moving forward. In this spirit, I also remove the .ruby-version file as testing across several versions is now done in CI This commit also restyles and adds a TravisCI badge to the README
danielrose7
force-pushed
the
add-travis-ci
branch
from
8eae275 to
31b0d05
Compare
2 participants
Contributor Self-Check:
Which GitHub Issues does this PR address?
#11
What does this PR do?
The had-been Codeship config had permissions tied to jzornow.
This commit adds Travis. The main benefit here is that we can easily test several versions of ruby with a super simple config.
How do I manually test this?
Check that the Travis build passes and has a decent looking config
GIF for how this PR makes me feel