Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Rename param#21

Merged
toddsiegel merged 1 commit into
masterfrom
rename_response
May 16, 2018
Merged

Rename param#21
toddsiegel merged 1 commit into
masterfrom
rename_response

Conversation

@toddsiegel
Copy link
Copy Markdown
Contributor

@danielpowell4 You 👍 with this?

http_response really describes what this thing is.
Copy link
Copy Markdown
Contributor

@danielrose7 danielrose7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me!

Assuming you tested it etc

Probably wait for passing build just in case

Good to update changelog as appropriate

@toddsiegel toddsiegel merged commit 255d206 into master May 16, 2018
@toddsiegel toddsiegel deleted the rename_response branch May 16, 2018 22:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants