Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Fix read type API calls#8

Closed
dior001 wants to merge 6 commits into
privateprep:masterfrom
scienceexchange:master
Closed

Fix read type API calls#8
dior001 wants to merge 6 commits into
privateprep:masterfrom
scienceexchange:master

Conversation

@dior001
Copy link
Copy Markdown

@dior001 dior001 commented Dec 29, 2017

@danielrose7
Copy link
Copy Markdown
Contributor

@dior001 I am working to get commit access to this repo

Sorry for the long response time

@jzornow
Copy link
Copy Markdown

jzornow commented Jan 18, 2018

@dior001 thanks for your contributions. It's a little hard for me to get a sense of how your changes will affect the API from a usage standpoint, specifically with respect to the changes you've made for camel case function names. (E.g. readByQuery). Would you mind submitting changes to the README as well with examples, so it's easier to me (and future users) to understand the new pattern?

My other ask is that you separate the change that you made for READ calls from the legacy API changes that you made. I think those are out of scope for this PR and warrant further discussion.

If you want to talk more on this, I'd be happy to set up some Skype time.

@danielrose7
Copy link
Copy Markdown
Contributor

Closing as it is addressed in #9 and hasn't had activity in a while

@danielrose7 danielrose7 closed this Mar 8, 2018
@danielrose7 danielrose7 mentioned this pull request Mar 8, 2018
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants