fix(plugin-e2e): add e2e-namespace input to fix startup_failure#152
Closed
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Closed
fix(plugin-e2e): add e2e-namespace input to fix startup_failure#152privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause fix for E2E startup_failure across multiple plugin repos.
The reusable workflow was missing the input declaration. Multiple plugin repos pass as a workflow input when calling :
But the reusable workflow only declared and inputs. Unknown inputs passed to a reusable workflow cause a workflow validation error at dispatch time, resulting in .
Fix: Added as an optional input to with default . The input value flows into so the workflow respects the caller's namespace choice.
Affected repos (will auto-pass after this merge):
cc @cpfarhood