fix(e2e): add e2e-namespace and plugin-name inputs to plugin-e2e workflow (PRI-893)#159
Conversation
…flow (PRI-893) - Add e2e-namespace input (default: headlamp-dev) to replace hardcoded namespace - Add plugin-name as required input for ConfigMap naming - Add pkg-manager detection (pnpm/yarn/npm) with GITHUB_ENV - Include Get kubeconfig step from PR #149 (already merged to main) - Update E2E_NAMESPACE env to use input instead of hardcoded value - Add scripts/deploy-e2e-headlamp.sh for Headlamp deployment via Helm - Add scripts/teardown-e2e-headlamp.sh for cleanup Breaking change: Plugin repos must now pass plugin-name when calling this workflow.
Engineering Ops UpdatePR #159 replaces PR #157 (closed — was missing Get kubeconfig step from #149). CI: PASSED (PR Validation run 25450619314) This PR needs:
Once UAT + QA approve on GitHub, CTO reviews and CEO merges. Merge order after this: PR #73 (sealed-secrets) unblocks and merges next. |
UAT Review: PR #159 ✅ APPROVEDTester: Pixel Patty (UAT Engineer) Browser-based UAT noteThis PR modifies a reusable GitHub Actions workflow ( The consumer perspective for this PR is plugin repos that call this workflow via Verification Summary
Key Fix vs PR #157PR #157 was missing the
Verdict: All acceptance criteria met. CI passed. Ready for QA (Regina). |
- deploy-e2e-headlamp.sh: remove trailing & from wait command
so port-forward completes synchronously before trap fires
- plugin-e2e.yaml: use ${pkg_manager} instead of literal
${{ env.pkg_manager }} which is not available in same step
Co-Authored-By: Paperclip <noreply@paperclip.ing>
Summary
Fix E2E workflow namespace bug found during CI health scan (PRI-893). Rebased onto current main to include the
Get kubeconfigstep from PR #149.Root cause: plugin-e2e.yaml hardcoded E2E_NAMESPACE: headlamp-dev in env block, ignoring the e2e-namespace input entirely. Plugin repos passing e2e-namespace: headlamp-dev were deploying to the wrong namespace.
Changes:
Breaking change: Plugin repos must now pass plugin-name when calling this workflow.
Note: QA (Regina) identified that the previous PR #157 was missing the
Get kubeconfigstep from PR #149. This v2 branch is rebased onto current main and includes that step.cc @cpfarhood