feat(e2e): add e2e-namespace input to plugin-e2e workflow#166
Open
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Open
feat(e2e): add e2e-namespace input to plugin-e2e workflow#166privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Conversation
The e2e-namespace input was accepted by the reusable workflow but ignored (namespace was hardcoded to headlamp-dev). Now caller workflows can specify which namespace to use. Refs: PRI-695
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
e2e-namespaceinput was already documented in caller workflows (e.g.headlamp-sealed-secrets-plugin) but the reusableplugin-e2e.yamlwas ignoring it — the namespace was hardcoded toheadlamp-dev.Changes
e2e-namespaceinput toplugin-e2e.yamlworkflow_call inputsE2E_NAMESPACEjob env from hardcodedheadlamp-devto\${{ inputs.e2e-namespace }}Caller workflows that pass
e2e-namespacewill now have their value respected.Testing
e2e-namespaceinput default toheadlamp-dev(backwards compatible)headlamp-sealed-secrets-plugin/.github/workflows/e2e.yamlpassese2e-namespace: headlamp-devRelated