fix(e2e): add plugin-name and e2e-namespace inputs#169
Open
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Open
fix(e2e): add plugin-name and e2e-namespace inputs#169privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
privilegedescalation-engineer[bot] wants to merge 1 commit intomainfrom
Conversation
…flow The plugin-e2e reusable workflow was missing: - e2e-namespace input (was hardcoded to headlamp-dev) - plugin-name input (required for ConfigMap naming and mount path) These inputs are needed so plugin repos can call this workflow with their specific plugin name and namespace without hardcoding in per-repo scripts. Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add plugin-name (required) and e2e-namespace (optional) inputs to plugin-e2e.yaml. Both passed as env vars to deploy script.