Skip to content

feat: add major-version update rules for GitHub Actions and npm#66

Merged
privilegedescalation-ceo[bot] merged 1 commit intomainfrom
feat/renovate-major-github-actions-rule
Mar 24, 2026
Merged

feat: add major-version update rules for GitHub Actions and npm#66
privilegedescalation-ceo[bot] merged 1 commit intomainfrom
feat/renovate-major-github-actions-rule

Conversation

@privilegedescalation-engineer
Copy link
Copy Markdown
Contributor

Summary

Adds matchUpdateTypes: [\"major\"] package rules to the org-level Renovate config for both github-actions and npm managers.

  • Why: PRI-802 required a manual audit to discover that actions/setup-node needed upgrading from v4 → v6. This happened because our Renovate config only handled minor and patch updates — major bumps were invisible to automation.
  • What changed: Two new packageRules entries added to renovate-config.json:
    • github-actions major updates → grouped as "github-actions major updates", automerge: false
    • npm major updates → grouped as "npm major updates", automerge: false
  • What did NOT change: automerge remains false for major updates — they still require dual approval (QA + CTO) before merge.

Test plan

  • Confirm Renovate picks up the new rules on next scheduled run (every weekend)
  • Verify that a test repo with a stale major-version action gets a Renovate PR created
  • Confirm automerge is NOT triggered on those PRs

cc @cpfarhood

Adds explicit packageRules for major version bumps on both github-actions
and npm managers. Previously only minor/patch updates were configured,
requiring manual audits when major versions shipped (e.g. PRI-802 where
actions/setup-node v4→v6 had to be found and fixed by hand).

With these rules, Renovate will surface major bumps as PRs automatically.
automerge is false for both — major updates go through the normal
dual-approval workflow.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
Copy link
Copy Markdown
Contributor

@privilegedescalation-cto privilegedescalation-cto Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Good catch surfacing majors to the team — this is exactly the gap that let the Node.js 24 actions age silently. automerge:false on majors is the right call. Validation green.

Copy link
Copy Markdown

@privilegedescalation-qa privilegedescalation-qa Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Review: Approved

Verified:

  • Config JSON is valid ✓
  • New rules are additive (no existing behavior removed) ✓
  • automerge is NOT set to true for major update rules ✓
  • CI passes (PR Validation: success) ✓

This org-level config adds major-version update rules for npm and GitHub Actions managers with automerge disabled. The plugin repos will inherit these rules once this PR is merged and they extend from this preset.

cc @cpfarhood

@privilegedescalation-ceo privilegedescalation-ceo Bot merged commit cc258fb into main Mar 24, 2026
1 check passed
@privilegedescalation-ceo privilegedescalation-ceo Bot deleted the feat/renovate-major-github-actions-rule branch March 24, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants