Skip to content

Add zapstore.yaml#256

Merged
kwsantiago merged 3 commits intomainfrom
Zapstore-whitelisting
Apr 21, 2026
Merged

Add zapstore.yaml#256
kwsantiago merged 3 commits intomainfrom
Zapstore-whitelisting

Conversation

@wksantiago
Copy link
Copy Markdown
Contributor

@wksantiago wksantiago commented Apr 21, 2026

Summary by CodeRabbit

  • Documentation

    • Added a manifest describing the Keep Android app: name, summary, detailed description, repository and public key metadata, classification tags, license, website, and supported Nostr protocols (NIPs 01, 44, 46, 55).
  • Chores

    • Updated version control rules so the app metadata manifest is now tracked.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 65d15146-0e89-4116-9a92-f33cd7770dee

📥 Commits

Reviewing files that changed from the base of the PR and between 7147c4f and 0c6cc36.

📒 Files selected for processing (1)
  • zapstore.yaml

Walkthrough

This PR removes the .gitignore rule excluding zapstore.yaml and adds a new zapstore.yaml manifest describing the Keep Android app (repository, pubkey, name, summary, description, tags, license, website, and supported Nostr NIPs 01/44/46/55).

Changes

Cohort / File(s) Summary
Gitignore
\.gitignore
Deleted the ignore entry for zapstore.yaml, allowing it to be tracked.
Zapstore manifest
zapstore.yaml
Added a manifest for the Keep Android app with repository/pubkey, name/summary/description, classification tags, license and website fields, and supported_nips: [01,44,46,55]. No code changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 A small YAML hop into view,
Keys and names in tidy queue,
No longer hidden, banner unfurled,
Keep's little manifest greets the world! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add zapstore.yaml' accurately and concisely describes the main change in the pull request: adding a new zapstore.yaml manifest file to the repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch Zapstore-whitelisting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@wksantiago wksantiago self-assigned this Apr 21, 2026
@wksantiago wksantiago linked an issue Apr 21, 2026 that may be closed by this pull request
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@zapstore.yaml`:
- Around line 1-2: The repository field in zapstore.yaml is set to a specific
release tag; update the repository value from
"https://github.com/privkeyio/keep-android/releases/tag/v1.0.0" to the
repository root "https://github.com/privkeyio/keep-android" so Zapstore can
auto-discover releases via the GitHub API; leave the pubkey (npub...) unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 40848c8e-e4b1-482c-a828-d262f4ac609b

📥 Commits

Reviewing files that changed from the base of the PR and between e4e8618 and 7147c4f.

📒 Files selected for processing (2)
  • .gitignore
  • zapstore.yaml
💤 Files with no reviewable changes (1)
  • .gitignore

Comment thread zapstore.yaml Outdated
@wksantiago
Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Contributor

@kwsantiago kwsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0c6cc36

@kwsantiago kwsantiago merged commit 1c250a1 into main Apr 21, 2026
1 of 4 checks passed
@kwsantiago kwsantiago deleted the Zapstore-whitelisting branch April 21, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup Zapstore whitelisting for first app publish (zapstore.yaml)

2 participants