Skip to content

feat(authorization): P-256 signing, RFC 8785 canonicalization, prepare helper#5

Merged
jagtejsodhi merged 1 commit into
nextfrom
llois-c/feat-authorization-with-p256
May 9, 2026
Merged

feat(authorization): P-256 signing, RFC 8785 canonicalization, prepare helper#5
jagtejsodhi merged 1 commit into
nextfrom
llois-c/feat-authorization-with-p256

Conversation

@lucasloisp
Copy link
Copy Markdown
Collaborator

@lucasloisp lucasloisp commented May 8, 2026

Committed-By-Agent: claude

This was referenced May 8, 2026
Merged
Merged
@lucasloisp Graphite App
Copy link
Copy Markdown
Collaborator Author

lucasloisp commented May 8, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced May 8, 2026
Merged
Merged
Merged
@lucasloisp lucasloisp force-pushed the llois-c/feat-authorization-with-p256 branch from 471e309 to ed90e04 Compare May 8, 2026 18:48
@lucasloisp lucasloisp force-pushed the llois-c/feat-privyclient-wrappet branch from d5750a1 to 5f75eb8 Compare May 8, 2026 19:16
@lucasloisp lucasloisp force-pushed the llois-c/feat-authorization-with-p256 branch from ed90e04 to 4a6b9f6 Compare May 8, 2026 19:16
lucasloisp
lucasloisp commented May 8, 2026
View reviewed changes
Comment thread lib/privy/authorization/authorization.rb
key = Privy::Authorization::Crypto.import_pkcs8_private_key(private_key_base64)
digest = OpenSSL::Digest.new("SHA256").digest(payload)
der = key.dsa_sign_asn1(digest)
[der].pack("m0")
Copy link
Copy Markdown
Collaborator Author

@lucasloisp lucasloisp May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pack m0 is idiomatic "encode as base64"

https://idiosyncratic-ruby.com/4-what-the-pack.html#m0--base64-encoding-rfc-4648

@lucasloisp lucasloisp marked this pull request as ready for review May 8, 2026 19:33
@lucasloisp lucasloisp requested a review from jagtejsodhi May 8, 2026 19:34
This was referenced May 8, 2026
Merged
Merged
Merged
Merged
@jagtejsodhi Graphite App
Copy link
Copy Markdown

jagtejsodhi commented May 8, 2026 •
edited
Loading

Merge activity

@jagtejsodhi jagtejsodhi changed the base branch from llois-c/feat-privyclient-wrappet to graphite-base/5 May 9, 2026 00:51
@jagtejsodhi jagtejsodhi changed the base branch from graphite-base/5 to next May 9, 2026 00:52
@jagtejsodhi jagtejsodhi force-pushed the llois-c/feat-authorization-with-p256 branch from 4a6b9f6 to 60f94d9 Compare May 9, 2026 00:53
@jagtejsodhi jagtejsodhi merged commit 8a7255f into next May 9, 2026
10 checks passed
@stainless-app stainless-app Bot mentioned this pull request May 9, 2026
Open
@jagtejsodhi jagtejsodhi mentioned this pull request May 9, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jagtejsodhi jagtejsodhi jagtejsodhi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucasloisp @jagtejsodhi