Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMS support for MockVcenter #3

Open
wants to merge 193 commits into
base: main
Choose a base branch
from

Commits on Dec 1, 2023

  1. Add KMIP support in VC sim

    Priyanka Jiandani committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    3aec987 View commit details
    Browse the repository at this point in the history
  2. Add KMS support

    Priyanka Jiandani committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    49669dd View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. vcsim: use node id for ServiceContent.InstanceUuid

    The uuid.NodeID function returns the node's (first) nic hardware address.
    Using this makes ServiceContent.InstanceUuid unique, yet stable.
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9045eba View commit details
    Browse the repository at this point in the history
  2. Add common stub for hgfs for non-linux env

    This change adds a common stub for the non-linux envs using buildtags.
    yashdesai93 authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    cbcf1ca View commit details
    Browse the repository at this point in the history
  3. Add new query selection parameters to be used for QueryAllVolume/Quer…

    …yVolumeAsync API
    akankshapanse authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    1ac0f21 View commit details
    Browse the repository at this point in the history
  4. Address review comments

    akankshapanse authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c0230e5 View commit details
    Browse the repository at this point in the history
  5. vcsim: Fix RetrieveProperties path validation to avoid panic

    Closes: vmware#2953
    Signed-off-by: syuparn <s.hello.spagetti@gmail.com>
    Syuparn authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    040f841 View commit details
    Browse the repository at this point in the history
  6. govc: Add feature sso.group.lsgroups using FindGroupsInGroup method

    Closes: vmware#2945
    Hrabur Stoyanov authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    39529ce View commit details
    Browse the repository at this point in the history
  7. govc: Add feature in sso.group.ls to list groups using FindGroupsInGr…

    …oup method
    
    govc: Add feature in sso.group.ls to list users using FindUsersInGroup method
    
    Closes: vmware#2945
    Hrabur Stoyanov authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    7a52766 View commit details
    Browse the repository at this point in the history
  8. move FindUsersInGroup to users.ls

    Closes: vmware#2945
    Hrabur Stoyanov authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    4a9b0e3 View commit details
    Browse the repository at this point in the history
  9. correct new lines in USAGE.md

    Hrabur Stoyanov authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c6d6ec2 View commit details
    Browse the repository at this point in the history
  10. correct new lines in group.ls

    Hrabur Stoyanov authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    904ae21 View commit details
    Browse the repository at this point in the history
  11. Updated USAGE.md

    Hrabur Stoyanov authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    296f09d View commit details
    Browse the repository at this point in the history
  12. build(deps): bump actions/stale from 5 to 6

    Bumps [actions/stale](https://github.com/actions/stale) from 5 to 6.
    - [Release notes](https://github.com/actions/stale/releases)
    - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
    - [Commits](actions/stale@v5...v6)
    
    ---
    updated-dependencies:
    - dependency-name: actions/stale
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9cca0e6 View commit details
    Browse the repository at this point in the history
  13. Add API cnsreconfigpolicy bindings and static check fixes to cns/clie…

    …nt_test.go
    sashrith authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    dd02609 View commit details
    Browse the repository at this point in the history
  14. api: Add SRIOV device names

    Closes vmware#2956
    
    Signed-off-by: Sunny Carter <sunny.carter@metaswitch.com>
    sunnycarter authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    68fe574 View commit details
    Browse the repository at this point in the history
  15. fixup! api: Add SRIOV device names

    sunnycarter authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    15cccee View commit details
    Browse the repository at this point in the history
  16. fixup! api: Add SRIOV device names

    sunnycarter authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    7816bad View commit details
    Browse the repository at this point in the history
  17. Update list of projects using govmomi

    [Elastic Agent VMware vSphere integration](https://github.com/elastic/integrations/tree/main/packages/vsphere) to the list of projects using govmomi.
    
    Signed-off-by: Essodjolo KAHANAM <essodjolo@kahanam.com>
    essodjolo authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9d41112 View commit details
    Browse the repository at this point in the history
  18. govc: fix host.esxcli runtime error occurred when no arguments specified

    Closes: vmware#2960
    Signed-off-by: syuparn <s.hello.spagetti@gmail.com>
    Syuparn authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    eb12a73 View commit details
    Browse the repository at this point in the history
  19. Fix: use latestPages in task HistoryCollector

    This change fixes the recentTasks errors in the task historyCollector.
    TaskHistoryCollector does not have a recentTask property,
    so this method always fails.
    Update to latestPage to fix this bug.
    Yi Jiang authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    6b42bfd View commit details
    Browse the repository at this point in the history
  20. Add optional recommRequired PlaceVmsXCluster req arguments

    PlaceVmsXCluster request has two optional bool fields as to whether host
    and/or datastore selection is required as a part of the placement response.
    
    Update simulator PlaceVmsXCluster response to include the ConfigSpec
    only when the datastore selection is required to match real VC behavior.
    bryanv authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    2db0055 View commit details
    Browse the repository at this point in the history
  21. build(deps): bump nokogiri from 1.13.6 to 1.13.9 in /gen

    Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.6 to 1.13.9.
    - [Release notes](https://github.com/sparklemotion/nokogiri/releases)
    - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
    - [Commits](sparklemotion/nokogiri@v1.13.6...v1.13.9)
    
    ---
    updated-dependencies:
    - dependency-name: nokogiri
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9b05166 View commit details
    Browse the repository at this point in the history
  22. build(deps): bump chuhlomin/render-template from 1.5 to 1.6

    Bumps [chuhlomin/render-template](https://github.com/chuhlomin/render-template) from 1.5 to 1.6.
    - [Release notes](https://github.com/chuhlomin/render-template/releases)
    - [Commits](chuhlomin/render-template@v1.5...v1.6)
    
    ---
    updated-dependencies:
    - dependency-name: chuhlomin/render-template
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    195a824 View commit details
    Browse the repository at this point in the history
  23. build(deps): bump andstor/file-existence-action from 1 to 2

    Bumps [andstor/file-existence-action](https://github.com/andstor/file-existence-action) from 1 to 2.
    - [Release notes](https://github.com/andstor/file-existence-action/releases)
    - [Commits](andstor/file-existence-action@v1...v2)
    
    ---
    updated-dependencies:
    - dependency-name: andstor/file-existence-action
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    65cc368 View commit details
    Browse the repository at this point in the history
  24. vcsim: add QueryNetworkHint support for LLDP and CDP details

    smahadikarkin authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    2918e97 View commit details
    Browse the repository at this point in the history
  25. vcsim: Fix duplicated name check in CloneVM_Task

    Closes: vmware#2983
    Signed-off-by: syuparn <s.hello.spagetti@gmail.com>
    Syuparn authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    28e5201 View commit details
    Browse the repository at this point in the history
  26. api: add Content Library security compliance support

    govc: add libray.trust{ls,info,create,rm} commands
    
    Fixes vmware#2980
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    b856915 View commit details
    Browse the repository at this point in the history
  27. govc: Add sso.lpp.info and sso.lpp.update commands

    Closes: vmware#2975
    Hrabur Stoyanov authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    5f29d96 View commit details
    Browse the repository at this point in the history
  28. govc: host.info: use writer instead of os.stdout

    Closes: vmware#2995
    markrexwinkel authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    02918ba View commit details
    Browse the repository at this point in the history
  29. govc: host.info: use writer instead of os.stdout

    Closes: vmware#2995
    markrexwinkel authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    afd029c View commit details
    Browse the repository at this point in the history
  30. docs: update README.md

    Updates the `README.md` for accuracy, readability, and maintainability:
    
    - Update the vSphere versions to refer to the VMware Product Lifecycle Matrix.
    - Add comment to disable `markdownlint` check for an H1 on the first line.
    - Moves all markdown links to the bottom of the file and use markdown references.
    - Condenses unordered lists markdown.
    - Removes links to notable projects that are not longer active.
    - Updatds links to the Terraform Provider for vSphere and Packer Plugin for vSphere.
    
    Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
    tenthirtyam authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f3a3635 View commit details
    Browse the repository at this point in the history
  31. govc: bash completion improvements

    Signed-off-by: Rianto Wahyudi <rwahyudi@gmail.com>
    rwahyudi authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    6d73346 View commit details
    Browse the repository at this point in the history
  32. perms on template files

    kbrock authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ba9b47e View commit details
    Browse the repository at this point in the history
  33. api: Update types to vSphere 8.0 GA

    This patch updates the generated types to vSphere 8.0 GA.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    407b915 View commit details
    Browse the repository at this point in the history
  34. govc: about.cert was not respecting -k

    This patch fixes a bug where "govc about.cert" was not respecting
    the -k flag (or env var) that disabled TLS verification.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9c19907 View commit details
    Browse the repository at this point in the history
  35. vcsim: Update test keys to be RSA 2048

    This patch updates the cert/key pairs vC Sim uses for testing to
    be RSA 2048 in accordance with Apple's new requirements on macOS.
    
    https://developer.apple.com/documentation/security/preventing_insecure_network_connections
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    96c5902 View commit details
    Browse the repository at this point in the history
  36. fix: DialTLSContext / Go 1.18+ CertificateVerify support

    This patch updates the GoVmomi SOAP client to use DialTLSContext
    instead of DialTLS, as the latter has been deprecated for multiple,
    major Go versions.
    
    This patch also updates how the SOAP client handles TLS validation
    with respect to thumbprints. Go 1.18+ adopted the host's certificate
    verification framework, so it is necessary to alter a few things to
    continue to support thumbprint verification.
    
    * https://tip.golang.org/doc/go1.18 (search for "Certificate.Verify")
    * square/certigo#264
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    1a8524d View commit details
    Browse the repository at this point in the history
  37. fix: Update $mktemp to support macOS

    This patch updates the instances of $mktemp in the govc/test/*.bats
    files to support the macOS variant.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    50c3269 View commit details
    Browse the repository at this point in the history
  38. fix: Heal the broken Namespace API

    This patch fixes a few bugs related to the Namespaces API. There
    was an NPE occurring due to a pointer variable being used prior to
    being assigned. The "govc namespace.logs.download" command also
    just failed to work due to the VAPI client assuming the response
    will always be JSON and not possibly, binary data as one sends when
    one receives a tar file. Finally, the namespace.bats file used to
    use the cluster name "Workload-Cluster", but due to a hack in the
    simulated namespaces API, it only recognizes clusters that begin
    with "WCP".
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    36ce582 View commit details
    Browse the repository at this point in the history
  39. Update CHANGELOG for v0.30.0

    Signed-off-by: GitHub <noreply@github.com>
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    2592a1a View commit details
    Browse the repository at this point in the history
  40. build(deps): bump nokogiri from 1.13.9 to 1.13.10 in /gen

    Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.9 to 1.13.10.
    - [Release notes](https://github.com/sparklemotion/nokogiri/releases)
    - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
    - [Commits](sparklemotion/nokogiri@v1.13.9...v1.13.10)
    
    ---
    updated-dependencies:
    - dependency-name: nokogiri
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    eb7e2d5 View commit details
    Browse the repository at this point in the history
  41. chore: Vendor Go 1.17.13 encoding/json

    This patch vendors the sources from Go 1.17.13's encoding/json
    package in the package vim25/json.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    0bca19b View commit details
    Browse the repository at this point in the history
  42. chore: JSON Encoding w Discriminator Support

    This patch introduces support for discriminators to the "encoding/json" package.
    A discriminator is a field in a JSON object that indicates the object's type.
    For example:
    
            {
                "breed": "Lab"
            }
    
    The above JSON does not indicate the Go type into which the object should be
    decoded. However, it is possible to store that Go type information along with
    the JSON:
    
            {
                "_typeName": "Dog",
                "breed": "Lab"
            }
    
    The "_typeName" field teaches the JSON decoder to unmarshal the object into the
    Go type named "Dog".
    
    This patch introduces functions for the json.Encoder and json.Decoder that may
    be used to active support for discriminators.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    d7684e2 View commit details
    Browse the repository at this point in the history
  43. chore: Include LICENSE in vendored JSON pkg

    This patch adds Go's LICENSE file to the vendored JSON package.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    cb559e7 View commit details
    Browse the repository at this point in the history
  44. docs: Add README to vendored JSON pkg

    This patch adds a README to the vendored JSON package describing
    its purpose and how to show the diff between the original sources
    and the patch applied to the vendored copy.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    b4a2341 View commit details
    Browse the repository at this point in the history
  45. chore: Exclude vim25/json from CodeStyle workflow

    This patch excludes the vendored vim25/json package from the
    GitHub action that checks code style for Go sources.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    bd7147e View commit details
    Browse the repository at this point in the history
  46. api: Generate JSON tags

    This patch updates the type generation code to support adding
    JSON tags to generated type field data.
    
    BREAKING:
    
    Updating the `vim25/types` with camelCased, JSON tags affects
    the output of the `govc` command when using the `-json` flag
    to emit results as JSON. Field names that used to be PascalCased
    will now be camelCased. Queries for tools that parse JSON, such
    as `jq`, will need to be updated to use the new camelCased fields.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    a071ebe View commit details
    Browse the repository at this point in the history
  47. api: JSON Discriminators for vim25/types

    This patch adds support to GoVmomi for marshaling/unmarshaling
    the vim25/types (and other VMODL1 types) to/from JSON using:
    
    * a customized version of the Golang encoding/json package that
      relies upon...
    * a new discriminator field added to every every complex object
      marshaled to JSON, the "_typeName" field. this field's value
      must match the value of the type's registered type name from
      the type registry
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    765d72e View commit details
    Browse the repository at this point in the history
  48. build(deps): bump goreleaser/goreleaser-action from 3 to 4

    Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 3 to 4.
    - [Release notes](https://github.com/goreleaser/goreleaser-action/releases)
    - [Commits](goreleaser/goreleaser-action@v3...v4)
    
    ---
    updated-dependencies:
    - dependency-name: goreleaser/goreleaser-action
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3bb0a07 View commit details
    Browse the repository at this point in the history
  49. chore: Move to main

    This patch prepares the repository for moving to the "main" branch.
    The following steps were taken to identify and change valid occurrences
    of "master" to "main":
    
    1. Replace obvious patterns:
    
        grep -rIl 'govmomi/[^/]\{1,\}/master' * | xargs -n1 -I% \
          sed -i.m2m -e 's~govmomi/\(.*\)/master~govmomi/\1/main~g' % && \
          find . -name '*.m2m' -type f -delete
    
    2. Replace instances in `RELEASE.md`:
    
        sed -i.m2m -e 's~master~main~g' RELEASE.md && rm -f RELEASE.md.m2m
    
    3. Replace instances in `CONTRIBUTING.md`:
    
        sed -i.m2m -e 's~vmware/master~main~g' CONTRIBUTING.md && \
          rm -f CONTRIBUTING.md.m2m
    
    4. Replace instances in `.goreleaser.yml`:
    
        sed -i.m2m -e 's~govmomi/\(.*\)/master~govmomi/\1/main~g' \
          .goreleaser.yml && rm -f .goreleaser.yml.m2m
    
    5. Replace instances in GitHub workflows:
    
        grep -rIl "'main', 'master'" .github/* | xargs -n1 -I% \
          sed -i.m2m -e "s~'main', 'master'~'main'~g" % && \
          find .github -name '*.m2m' -type f -delete
    
        grep -rIl '"main", "master"' .github/* | xargs -n1 -I% \
          sed -i.m2m -e 's~"main", "master"~"main"~g' % && \
          find .github -name '*.m2m' -type f -delete
    
        sed -i.m2m -e 's~master~main~g' \
          .github/workflows/codeql-analysis.yml && \
          rm -f .github/workflows/codeql-analysis.yml.m2m
    
        sed -i.m2m -e 's~master branch~main branch~g' \
          -e 's~refs/heads/master~refs/heads/main~g' \
          -e 's~ref: "master"~ref: "main"~g' \
          .github/workflows/govmomi-release.yaml && \
          rm -f .github/workflows/govmomi-release.yaml.m2m
    
        grep -rIl 'govmomi/[^/]\{1,\}/master' .github/* | xargs -n1 -I% \
          sed -i.m2m -e 's~govmomi/\(.*\)/master~govmomi/\1/main~g' % && \
          find .github -name '*.m2m' -type f -delete
    
    6. Replace the project's default version:
    
        sed -i.m2m 's~master~main~g' ./internal/version/version.go && \
          rm -f ./internal/version/version.go.m2m
    
    7. Searched for all other instances of the word `master` and manually
       verified they do not refer to this repository:
    
        find . -type f -not -path './.git/*' -exec grep -IH master \{\} \;
    
       For example:
    
        $ find . -type f -not -path './.git/*' -exec grep -IH master \{\} \;
        ./CHANGELOG.md:- [0422a07]	Merge branch 'master' into pc/HardwareInfoNotReplicatingInCloning
        ./CHANGELOG.md:- [a5c9e1f]	Merge branch 'master' into master
        ./CHANGELOG.md:- [86375ce]	Merge branch 'master' into fields-info
        ./CHANGELOG.md:- [26ba22d]	Merge branch 'gavrie-master'
        ./CHANGELOG.md:- [8dbb438]	Merge remote-tracking branch 'upstream/master' into event_manager
        ./govc/flags/int64.go:// https://github.com/golang/go/blob/master/src/cmd/internal/obj/flag.go
        ./govc/flags/int32.go:// https://github.com/golang/go/blob/master/src/cmd/internal/obj/flag.go
        ./govc/test/images/update.sh:wget -qN https://github.com/icebreaker/floppybird/raw/master/build/floppybird.img
        ./govc/test/README.md:        curl https://raw.githubusercontent.com/nektos/act/master/install.sh | sudo bash
        ./govc/test/vendor/manifest:			"branch": "master",
        ./govc/USAGE.md:  -mgmt-network.floating-IP=               Optional. The Floating IP used by the HA master cluster in the when network Mode is DHCP.
        ./govc/namespace/cluster/enable.go:	ControlPlaneManagementNetwork          masterManagementNetwork
        ./govc/namespace/cluster/enable.go:type masterManagementNetwork struct {
        ./govc/namespace/cluster/enable.go:		ControlPlaneManagementNetwork: masterManagementNetwork{
        ./govc/namespace/cluster/enable.go:		"Optional. The Floating IP used by the HA master cluster in the when network Mode is DHCP.")
        ./govc/namespace/cluster/enable.go:	var masterManagementNetwork *namespace.MasterManagementNetwork
        ./govc/namespace/cluster/enable.go:		masterManagementNetwork = &namespace.MasterManagementNetwork{}
        ./govc/namespace/cluster/enable.go:		masterManagementNetwork.AddressRange = cmd.ControlPlaneManagementNetwork.AddressRange
        ./govc/namespace/cluster/enable.go:		masterManagementNetwork.FloatingIP = cmd.ControlPlaneManagementNetwork.FloatingIP
        ./govc/namespace/cluster/enable.go:		masterManagementNetwork.Mode = &ipam
        ./govc/namespace/cluster/enable.go:		masterManagementNetwork.Network = cmd.ControlPlaneManagementNetwork.Network
        ./govc/namespace/cluster/enable.go:	if masterManagementNetwork != nil {
        ./govc/namespace/cluster/enable.go:		if (masterManagementNetwork.AddressRange.SubnetMask == "") &&
        ./govc/namespace/cluster/enable.go:			(masterManagementNetwork.AddressRange.StartingAddress == "") &&
        ./govc/namespace/cluster/enable.go:			(masterManagementNetwork.AddressRange.Gateway == "") &&
        ./govc/namespace/cluster/enable.go:			(masterManagementNetwork.AddressRange.AddressCount == 0) {
        ./govc/namespace/cluster/enable.go:			masterManagementNetwork.AddressRange = nil
        ./govc/namespace/cluster/enable.go:		masterManagementNetwork.Network = refs.Network
        ./govc/namespace/cluster/enable.go:		MasterManagementNetwork:                masterManagementNetwork,
        ./govc/README.md:* [Create a Debian VM](https://github.com/kubernetes/kubernetes/tree/master/cluster/vsphere)
        ./govc/README.md:* [Create a Windows VM](https://github.com/dougm/govc-windows-box/blob/master/provision-esx.sh)
        ./govc/vm/rdm/attach.go://This file in particular https://github.com/codedellemc/govmax/blob/master/api/v1/vmomi.go
        ./vim25/types/enum.go:	ClusterDasFdmAvailabilityStateMaster                       = ClusterDasFdmAvailabilityState("master")
        ./vim25/types/enum.go:	VsanHostNodeStateMaster                  = VsanHostNodeState("master")
        ./vim25/mo/retrieve_test.go:	if vm.Config.Name != "kubernetes-master" {
        ./vim25/mo/fixtures/nested_property.xml:      <val xsi:type="xsd:string">kubernetes-master</val>
        ./gen/sdk/vim-types.xsd:         <enumeration value="master" />
        ./gen/sdk/vim-types.xsd:         <enumeration value="master" />
        ./gen/sdk/internalvim-types.xsd:         <enumeration value="master" />
        ./gen/sdk/internalvim-types.xsd:         <enumeration value="master" />
        ./README.md:[project-docker-linuxKit]: https://github.com/linuxkit/linuxkit/tree/master/src/cmd/linuxkit
        ./README.md:[project-influxdata-telegraf]: https://github.com/influxdata/telegraf/tree/master/plugins/inputs/vsphere
        ./README.md:[project-rancher]: https://github.com/rancher/rancher/blob/master/pkg/api/norman/customization/vsphere/listers.go
        ./vcsim/README.md:* [Kubernetes](https://github.com/kubernetes/kubernetes/tree/master/pkg/cloudprovider/providers/vsphere)
        ./vcsim/README.md:* [Telegraf](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/vsphere)
        ./vcsim/README.md:* [LocalStack](https://github.com/localstack/localstack/blob/master/README.md#why-localstack)
        ./toolbox/README.md:* [VIC tether toolbox extension](https://github.com/vmware/vic/blob/master/lib/tether/toolbox.go)
        ./toolbox/README.md:* [VIC container host tether](https://github.com/vmware/vic/blob/master/cmd/vic-init/main_linux.go)
        ./toolbox/hgfs/server.go:// See: https://github.com/vmware/open-vm-tools/blob/master/open-vm-tools/lib/hgfsServer/hgfsServer.c
        ./toolbox/hgfs/protocol.go:// See: https://github.com/vmware/open-vm-tools/blob/master/open-vm-tools/lib/include/hgfsProto.h
        ./scripts/devbox/README.md:This script is a fork of the [VIC devbox](https://github.com/vmware/vic/tree/master/infra/machines/devbox),
        ./scripts/devbox/README.md:[vcp]:https://github.com/kubernetes/kubernetes/tree/master/pkg/cloudprovider/providers/vsphere
        ./scripts/devbox/README.md:As an alternative to the [VIC devbox](https://github.com/vmware/vic/tree/master/infra/machines/devbox).
        ./.github/workflows/govmomi-go-lint.yaml:          curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh | sh -s -- -b "${TEMP_PATH}" 2>&1
        ./.github/workflows/govmomi-release.yaml:            > Due to a [limitation](https://github.com/peter-evans/create-pull-request/blob/master/docs/concepts-guidelines.md#triggering-further-workflow-runs) in Github Actions please **close and immediately reopen** this PR to trigger the required workflow checks before merging.
        ./vapi/namespace/namespace.go:	MasterDNSSearchDomains []string               `json:"master_DNS_search_domains,omitempty"`
        ./vapi/namespace/namespace.go:	MasterManagementNetwork *MasterManagementNetwork    `json:"master_management_network"`
        ./vapi/namespace/namespace.go:	MasterNTPServers        []string                    `json:"master_NTP_servers,omitempty"`
        ./vapi/namespace/namespace.go:	MasterDNS            []string              `json:"master_DNS,omitempty"`
        ./vapi/namespace/namespace.go:	MasterStoragePolicy                    string                  `json:"master_storage_policy,omitempty"`
        ./vsan/types/types.go:	Master  string   `xml:"master"`
        ./vsan/types/types.go:	MasterInfo     *VsanPerfMasterInformation `xml:"masterInfo,omitempty"`
    
    BREAKING:
    
    Changing GoVmomi's default branch from `master` to `main` will likely result
    in dependents needing to repoint their clients and other integrations to
    the new, default branch.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    b81da37 View commit details
    Browse the repository at this point in the history
  50. fix: Pin the result limit of ssoadmin client to its MAX

    Closes: vmware#3004
    HakanSunay authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    e17add8 View commit details
    Browse the repository at this point in the history
  51. build(deps): bump actions/stale from 6 to 7

    Bumps [actions/stale](https://github.com/actions/stale) from 6 to 7.
    - [Release notes](https://github.com/actions/stale/releases)
    - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
    - [Commits](actions/stale@v6...v7)
    
    ---
    updated-dependencies:
    - dependency-name: actions/stale
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    2887d9f View commit details
    Browse the repository at this point in the history
  52. govc: Add feature to get and set default idp

    Closes: vmware#3023
    Hrabur Stoyanov authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    fac466a View commit details
    Browse the repository at this point in the history
  53. chore: Remove JSON tag for "This" / ArrayOf "_value"

    This patch removes the JSON tag for properties named "This" of
    type "ManagedObjectReference" as VMware's SOAP over JSON project
    does not use this.
    
    This patch also ensures any of the "ArrayOf" types use the type
    discriminator name "_value" for the name of the type's single
    field which is a slice.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    2c41a04 View commit details
    Browse the repository at this point in the history
  54. govc: Add checksum validation to govc import.ova

    This patch enhances govc import.ova command to validate the checksum
    of an uploaded file (e.g. .vmdk file in .ova) - as computed by the
    remote server with the checksum listed in the ova manifest (.mf file
    in .ova). govc import.ova takes a new optional flag to indicate
    strict checksum validation.
    (This govc enhancement needed a small tweak in nfc/lease.go code
    to actually return manifest data in GetManifest() API.)
    
    This patch also modifies simulator to compute checksum of uploaded
    file and return that metadata through HttpNfcLeaseGetManifest() call.
    
    govc ova import test now has a new sub-test to test for ova with
    valid checksum and ova with invalid checksum.
    
    Closes: vmware#1978
    nikhail authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    44f60f4 View commit details
    Browse the repository at this point in the history
  55. chore: bats related fixes

    - Commit 1991de5 recently changed the json tag for ArrayOf types
    
    - Fix 'vcsim run container' test when using MacOS / Docker desktop
    
    - Change vcsim/main.go to open the fifo after its running
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    bb3b441 View commit details
    Browse the repository at this point in the history
  56. vcsim: add guest.net.ipConfig

    This is needed to support the VirtualMachine.WaitForNetIP helper against vcsim
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ead4fbd View commit details
    Browse the repository at this point in the history
  57. lookup.EndpointURL should only save thumbprints for endpoints outside…

    … of vCenter
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    69b4657 View commit details
    Browse the repository at this point in the history
  58. Use string pointer for library/item description field.

    This commit includes:
    - Change library/item description field from string to a string pointer.
    This can help distinguish if the item description is unset or set to an empty string when updating the library item.
    - govc now supports setting library/item description to empty.
    
    BREAKING: change string to *string for Item.Description and Library.Description in package library
    
    Testing done:
    - Test against a VC testbed
    Sending a UpdateLibraryItem request with this change, and set the new description to "".
    The original item description was "virtualmachinepublishrequest.vmware.com: 6b0d06ad-8e18-4881-a806-2a7c8a7e1b4b",
    after this UpdateLibraryItem request succeeded, the item description was set to "".
    While before this change, it would be a no-op for the description.
    - Test using govc
      - Update Library
    ```
    Create a library:
    ➜  govmomi git:(issue-3048) ✗ govc library.create -d "description-1" cl-1
    495f611a-cf74-40d6-a54a-8b239cf15406
    ➜  govmomi git:(issue-3048) ✗ ~/go/bin/govc library.info 495f611a-cf74-40d6-a54a-8b239cf15406
    Name:                 cl-1
      ID:                 495f611a-cf74-40d6-a54a-8b239cf15406
      Path:               /cl-1
      Description:        description-1
      Version:            2
      Created:            Fri Feb 17 19:18:22 2023
      Security Policy ID
      StorageBackings:
        DatastoreID:      sharedVmfs-0
        Type:             DATASTORE
    
    Update the library description with new string:
    ➜  govmomi git:(issue-3048) ✗ ~/go/bin/govc library.update -d "new description" 495f611a-cf74-40d6-a54a-8b239cf15406
    ➜  govmomi git:(issue-3048) ✗ ~/go/bin/govc library.info 495f611a-cf74-40d6-a54a-8b239cf15406
    Name:                 cl-1
      ID:                 495f611a-cf74-40d6-a54a-8b239cf15406
      Path:               /cl-1
      Description:        new description
      Version:            3
      Created:            Fri Feb 17 19:18:22 2023
      Security Policy ID
      StorageBackings:
        DatastoreID:      sharedVmfs-0
        Type:             DATASTORE
    
    Update the item name, description is not erased.
    ➜  govmomi git:(issue-3048) ✗ ~/go/bin/govc library.update -n "cl-1-new" 495f611a-cf74-40d6-a54a-8b239cf15406
    ➜  govmomi git:(issue-3048) ✗ ~/go/bin/govc library.info 495f611a-cf74-40d6-a54a-8b239cf15406
    Name:                 cl-1-new
      ID:                 495f611a-cf74-40d6-a54a-8b239cf15406
      Path:               /cl-1-new
      Description:        new description
      Version:            4
      Created:            Fri Feb 17 19:18:22 2023
      Security Policy ID
      StorageBackings:
        DatastoreID:      sharedVmfs-0
        Type:             DATASTORE
    
    Update the library description with empty string:
    ➜  govmomi git:(issue-3048) ✗ ~/go/bin/govc library.update -d ""
    495f611a-cf74-40d6-a54a-8b239cf15406
    ➜  govmomi git:(issue-3048) ✗ ~/go/bin/govc library.info 495f611a-cf74-40d6-a54a-8b239cf15406
    Name:                 cl-1-new
      ID:                 495f611a-cf74-40d6-a54a-8b239cf15406
      Path:               /cl-1-new
      Description:
      Version:            5
      Created:            Fri Feb 17 19:18:22 2023
      Security Policy ID
      StorageBackings:
        DatastoreID:      sharedVmfs-0
        Type:             DATASTORE
    ```
      - Update Library Item
    ```
    ➜  govmomi git:(issue-3048) ✗ ~/go/bin/govc library.update -d "item-2" /cl-1/image-2
    ➜  govmomi git:(issue-3048) ✗ ~/go/bin/govc library.info /cl-1/image-2
    Name:                   image-2
      ID:                   0dc7df56-31e0-47dc-8b0a-6a33279ddccc
      Path:                 /cl-1/image-2
      Description:          item-2
      Type:                 ovf
      Size:                 2.0GB
      Created:              Wed Feb 15 23:05:15 2023
      Modified:             Fri Feb 17 19:29:54 2023
      Version:              3
      Security Compliance:  true
      Certificate Status:   INTERNAL
    
    Update item name:
    govmomi git:(issue-3048) ✗ ~/go/bin/govc library.update -n "image-2-new" /cl-1/image-2
    ➜  govmomi git:(issue-3048) ✗ ~/go/bin/govc library.info /cl-1/image-2-new
    Name:                   image-2-new
      ID:                   0dc7df56-31e0-47dc-8b0a-6a33279ddccc
      Path:                 /cl-1/image-2-new
      Description:          item-2
      Type:                 ovf
      Size:                 2.0GB
      Created:              Wed Feb 15 23:05:15 2023
      Modified:             Fri Feb 17 19:31:44 2023
      Version:              4
      Security Compliance:  true
      Certificate Status:   INTERNAL
    
    Update item description to empty string
    ➜  govmomi git:(issue-3048) ✗ ~/go/bin/govc library.update -d "" /cl-1/image-2-new
    ➜  govmomi git:(issue-3048) ✗ ~/go/bin/govc library.info /cl-1/image-2-new
    Name:                   image-2-new
      ID:                   0dc7df56-31e0-47dc-8b0a-6a33279ddccc
      Path:                 /cl-1/image-2-new
      Description:
      Type:                 ovf
      Size:                 2.0GB
      Created:              Wed Feb 15 23:05:15 2023
      Modified:             Fri Feb 17 19:32:56 2023
      Version:              5
      Security Compliance:  true
      Certificate Status:   INTERNAL
    ```
    Yi Jiang authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    a7c816e View commit details
    Browse the repository at this point in the history
  59. build(deps): bump golang.org/x/text from 0.3.7 to 0.3.8 in /hack/tools

    Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.7 to 0.3.8.
    - [Release notes](https://github.com/golang/text/releases)
    - [Commits](golang/text@v0.3.7...v0.3.8)
    
    ---
    updated-dependencies:
    - dependency-name: golang.org/x/text
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    5079c40 View commit details
    Browse the repository at this point in the history
  60. govc: Add feature VM IOMMU enablement support

    Closes: vmware#3055
    Your Name authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8986e63 View commit details
    Browse the repository at this point in the history
  61. api: support find.Network by cluster path

    Datacenter's network folder may contain items with the same name.
    For clusters that have one such instance of a given network name, the cluster inventory path will be unique.
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    dee852d View commit details
    Browse the repository at this point in the history
  62. api: support find.NetworkList by ID

    Rather than limit by ID search to find.Network, move the logic to NetworkList to support both methods.
    
    Add finder_test (meant to include with PR vmware#2626)
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    1c952f4 View commit details
    Browse the repository at this point in the history
  63. govc: add sso.idp.ldap.update command

    Closes: vmware#3057
    Hrabur Stoyanov authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    45d590c View commit details
    Browse the repository at this point in the history
  64. build(deps): bump actions/setup-go from 3 to 4

    Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 4.
    - [Release notes](https://github.com/actions/setup-go/releases)
    - [Commits](actions/setup-go@v3...v4)
    
    ---
    updated-dependencies:
    - dependency-name: actions/setup-go
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    7e875a9 View commit details
    Browse the repository at this point in the history
  65. chore: upgrade golangci-lint

    With goimports also upgraded, several comment whitespace related changes have been made.
    
    Updated scripts/license.sh to only change the year range on files modified in the current branch.
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    586cf58 View commit details
    Browse the repository at this point in the history
  66. chore: Update CI to Go 1.20

    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    90dceba View commit details
    Browse the repository at this point in the history
  67. chore: adjust cert trust checks to support newer Go versions

    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ed6f2b8 View commit details
    Browse the repository at this point in the history
  68. vcsim: add ssoadmin user and group management

    The ssoadmin endpoint is now used for authentication for both SOAP and REST endpoints.
    Previous behavior is retained:
    - By default, any non-empty username + password is authenticated
    - If vcsim '-username' and '-password' flags are given, only those credentials can be used for authentication
    
    Additional users can be added via the ssoadmin APIs or using govc for example:
    
      % govc sso.user.create -p password govc
    
    Closes vmware#2852
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    760e19d View commit details
    Browse the repository at this point in the history
  69. api: Add ServerGuid to gen'd MoRef

    This patch manually introduces the ServerGuid field to
    the generated types.ManagedObjectReference type. This
    field is used internally at VMware and not part of the
    public WSDL, but given internal projects make use of this
    field, it is helpful for GoVmomi to know about it so it
    can be part of serialization/deserialization for both
    XML and JSON.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    975f793 View commit details
    Browse the repository at this point in the history
  70. govc: dont check poweredOn for vm.console vmrc requests

    Closes: vmware#2127
    xarem authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    499387c View commit details
    Browse the repository at this point in the history
  71. examples: add session.Manager.LoginByToken

    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    16e4820 View commit details
    Browse the repository at this point in the history
  72. examples: add rest.Client.LoginByToken

    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    94023d9 View commit details
    Browse the repository at this point in the history
  73. build(deps): bump actions/stale from 7 to 8

    Bumps [actions/stale](https://github.com/actions/stale) from 7 to 8.
    - [Release notes](https://github.com/actions/stale/releases)
    - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
    - [Commits](actions/stale@v7...v8)
    
    ---
    updated-dependencies:
    - dependency-name: actions/stale
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    90c317f View commit details
    Browse the repository at this point in the history
  74. chore: add timeout to bats tests

    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    503e9ad View commit details
    Browse the repository at this point in the history
  75. chore: sync httptest/server race fix

    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    d89c9f7 View commit details
    Browse the repository at this point in the history
  76. chore: fix jq query case

    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ee5a312 View commit details
    Browse the repository at this point in the history
  77. chore: upgrade to bats-core v1.9.0 release

    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    33f62d3 View commit details
    Browse the repository at this point in the history
  78. chore: remove sso bats test hacks

    fixed by upgrading to bats-core
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    35e35dd View commit details
    Browse the repository at this point in the history
  79. chore: fix WaitForUpdates bats test race

    The test uses govc object.collect to wait for 1 update.
    The following rename command may happen before the background process is parked in WaitForUpdates,
    leaving object.collect to hang.
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    0cfd7b7 View commit details
    Browse the repository at this point in the history
  80. fix: support govc ls -xml flag

    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    e4ffe4d View commit details
    Browse the repository at this point in the history
  81. api: Add JSON transport for vim25

    Closes: vmware#3062
    
    This change uses the JSON encoding package from github.com/akutz/gdj to
    implement a JSON transport for API calls to vCenter.
    
    The main parts of the change include:
    
    1. Clobber json encoding package with github.com/akutz/gdj
    2. Add mapping for VMOMI primitive names to Go types
    3. Add SOAP Client support for JSON transport with a property
    4. Implement a JSON transport
    5. Update version of the API to a valid 8.0.0.1 value
    6. go.mod includes github.com/stretchr/testify to test json equality
    karaatanassov authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    2be8488 View commit details
    Browse the repository at this point in the history
  82. govc: Support JSON protocol using environment variable

    Closes: vmware#3062
    
    `export GOVC_VI_JSON=TRUE` to switch XML communication to JSON.
    
    This is experimental attempt to get json working in govc. It requires a
    vCenter 8.0.1.0.
    
    There are no bat tests yet as vcsim does not yet know how to talk json.
    
    Testing done: Run `datacenter.info` and `folder.info` against a vCenter
    server. Observed the network traffic with `-trace` - it is JSON and the
    communication works.
    karaatanassov authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    01a6ab9 View commit details
    Browse the repository at this point in the history
  83. build(deps): bump peter-evans/create-pull-request from 4 to 5

    Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 4 to 5.
    - [Release notes](https://github.com/peter-evans/create-pull-request/releases)
    - [Commits](peter-evans/create-pull-request@v4...v5)
    
    ---
    updated-dependencies:
    - dependency-name: peter-evans/create-pull-request
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    23c8312 View commit details
    Browse the repository at this point in the history
  84. build(deps): bump peter-evans/create-or-update-comment from 2 to 3

    Bumps [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment) from 2 to 3.
    - [Release notes](https://github.com/peter-evans/create-or-update-comment/releases)
    - [Commits](peter-evans/create-or-update-comment@v2...v3)
    
    ---
    updated-dependencies:
    - dependency-name: peter-evans/create-or-update-comment
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    6c8cced View commit details
    Browse the repository at this point in the history
  85. chore: Err on json.Decode for invalid type/vals

    This patch updates the behavior of the JSON codec
    package so that if the decode operation cannot
    convert a value into the destination type, the error
    is no longer ignored silently, but returned so the
    caller can handle it.
    
    This patch also adds tests to validate these cases.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    935f75c View commit details
    Browse the repository at this point in the history
  86. Make mounting DMI information optional with docker-backed vcsim

    BrianMMcClain authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8f5f605 View commit details
    Browse the repository at this point in the history
  87. api: set inventory path in SearchIndex.FindByInventoryPath

    Closes: vmware#3095
    Signed-off-by: syuparn <s.hello.spagetti@gmail.com>
    Syuparn authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    87062a5 View commit details
    Browse the repository at this point in the history
  88. build(deps): bump nokogiri from 1.13.10 to 1.14.3 in /gen

    Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.10 to 1.14.3.
    - [Release notes](https://github.com/sparklemotion/nokogiri/releases)
    - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
    - [Commits](sparklemotion/nokogiri@v1.13.10...v1.14.3)
    
    ---
    updated-dependencies:
    - dependency-name: nokogiri
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    89a26b3 View commit details
    Browse the repository at this point in the history
  89. fix: only limit the number of samples generated to maxSample when max…

    …Sample is greater than 0 and the number of samples to generate is greater than maxSample
    
    Closes: vmware#3097
    jsleblanc authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    eeb6c9c View commit details
    Browse the repository at this point in the history
  90. vcsim: Add CSV format support to QueryPerf API

    jsleblanc authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8a52a37 View commit details
    Browse the repository at this point in the history
  91. Add RUN.port.xx flag to publish ports on container backed VM

    BrianMMcClain authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    726d281 View commit details
    Browse the repository at this point in the history
  92. build(deps): bump github.com/google/go-cmp from 0.5.7 to 0.5.9

    Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.7 to 0.5.9.
    - [Release notes](https://github.com/google/go-cmp/releases)
    - [Commits](google/go-cmp@v0.5.7...v0.5.9)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/google/go-cmp
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c44f46e View commit details
    Browse the repository at this point in the history
  93. govc: Add support for CNS volume snapshots

    Add support for creating, listing and removing snapshots from CNS volumes by implementing the following commands:
    - govc volume.snapshot.create VOL_ID DESC
    - govc volume.snapshot.ls VOL_ID
    - govc volume.snapshot.rm SNAP_ID VOL_ID
    
    Batch operations are supported by 'volume.snapshot.ls' and 'volume.snapshot.rm'.
    grandeit authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    7686ad1 View commit details
    Browse the repository at this point in the history
  94. fix: include StoragePod Datastore children in ContainerView

    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    e7ddb0b View commit details
    Browse the repository at this point in the history
  95. fix: avoid govc -verbose flag panic if an UpdateSet is nil

    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    eacc3cb View commit details
    Browse the repository at this point in the history
  96. govc: add cluster.mv command

    vcsim: add ClusterComputeResource.MoveInto_Task support
    
    Closes vmware#2524
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f988a4b View commit details
    Browse the repository at this point in the history
  97. fix: byte, float and int (de) serialization

    Added mapping for float.
    Fixed the mappings for byte to use uint8.
    Changed type name lookup order to use the external mapping before
    built-in table. This fixes int deserialization.
    
    Closes vmware#3121
    karaatanassov authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    bd738f2 View commit details
    Browse the repository at this point in the history
  98. govc: add detail error message for host.esxcli commands

    liron-l authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    32c5b76 View commit details
    Browse the repository at this point in the history
  99. vcsim: Fix FindByInventoryPath to handle root folder

    Closes: vmware#3119
    Signed-off-by: syuparn <s.hello.spagetti@gmail.com>
    Syuparn authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8775070 View commit details
    Browse the repository at this point in the history
  100. build(deps): bump chuhlomin/render-template from 1.6 to 1.7

    Bumps [chuhlomin/render-template](https://github.com/chuhlomin/render-template) from 1.6 to 1.7.
    - [Release notes](https://github.com/chuhlomin/render-template/releases)
    - [Commits](chuhlomin/render-template@v1.6...v1.7)
    
    ---
    updated-dependencies:
    - dependency-name: chuhlomin/render-template
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    256d3fb View commit details
    Browse the repository at this point in the history
  101. fix: add esxcli.Fault and revert Error() string

    PR vmware#3072 added fault detail to the error message, breaking existing code at runtime.
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    b7aad2c View commit details
    Browse the repository at this point in the history
  102. build(deps): bump github.com/stretchr/testify from 1.8.2 to 1.8.3

    Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.2 to 1.8.3.
    - [Release notes](https://github.com/stretchr/testify/releases)
    - [Commits](stretchr/testify@v1.8.2...v1.8.3)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/stretchr/testify
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    473e4ba View commit details
    Browse the repository at this point in the history
  103. Rm SetIndent in json.NewEncoder / JSON file name

    This patch removes the SetIndent function in the
    helper func NewJSONEncoder as it broke downstream tests.
    This patch also collapses the files back into json.go and
    json_test.go.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    dce19d8 View commit details
    Browse the repository at this point in the history
  104. fix: support binary and dateTime in JSON

    This change adds support for `binary` and `dateTime` in JSON.
    
    For `binary` golang `[]byte` JSON serialization matches the vCenter
    format. Thus adding the name ot the maps was enough.
    
    For `dateTime` the format of `time.Time` `Marshaler` and `Unmarshaler`
    matches vCenter format. The discriminator code required support for
    custom marshaling logic. In addition the name had to be mapped.
    
    To support `nil` value fields move `assertEqual` to use
    `reflect.DeepEqual`.
    
    Closes: vmware#3127
    karaatanassov authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    fa97f38 View commit details
    Browse the repository at this point in the history
  105. chore: bump embano1/wip

    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    4a8894a View commit details
    Browse the repository at this point in the history
  106. vcsim: add VirtualMachine.StandbyGuest support

    govc: add vm.power -standby option
    
    api: add object.VirtualMachine.StandbyGuest method
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c512959 View commit details
    Browse the repository at this point in the history
  107. chore: add missing guest OS IDs

    Kristian Alvestad authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    757128c View commit details
    Browse the repository at this point in the history
  108. build(deps): bump github.com/stretchr/testify from 1.8.3 to 1.8.4

    Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.3 to 1.8.4.
    - [Release notes](https://github.com/stretchr/testify/releases)
    - [Commits](stretchr/testify@v1.8.3...v1.8.4)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/stretchr/testify
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9186156 View commit details
    Browse the repository at this point in the history
  109. vcsim: async guest shutdown and standby

    GuestShutdown and GuestStandby methods don't block when called in real vCenter,
    but the VM power state transition won't happen until somtime after the guest has actually shutdown.
    It is also possible for shutdown to hang indefinitely.
    To simulate such behavior, an internal task is now used to transition state, which can be optionally delayed.
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    02e92bd View commit details
    Browse the repository at this point in the history
  110. vcsim: Fix VM ExtraConfig

    This patch fixes a bug in the simulator where applying updated
    values for a VM's ExtraConfig would not take. Nor was it possible
    to remove values. Both issues are now addressed.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    fcef9ab View commit details
    Browse the repository at this point in the history
  111. vcsim: make task lock handoff optional

    As PR vmware#2351 explains:
      This commit guarantees that a lock held by the handler func (ie, the lock on the handler itself)
      is held by the async goroutine without the possibility of someone else getting the lock in between.
    
    However, with a TaskDelay, PropertyCollector (for example) cannot read any object properties while the lock is held.
    
    This workaround provides an option to disable the lock handoff -
    so we don't lock during the delay, only lock while the task is actually running.
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    5422b9a View commit details
    Browse the repository at this point in the history
  112. govc: Add general usage message

    Closes: vmware#3054
    CarstenGrohmann authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    675fc13 View commit details
    Browse the repository at this point in the history
  113. fix: grep warnings during generating usage documentation

    to prevent `grep: warning: stray \ before -` and accidental non-zero return
    codes
    CarstenGrohmann authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    6e7d900 View commit details
    Browse the repository at this point in the history
  114. govc: Add --help

    CarstenGrohmann authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    eec67f7 View commit details
    Browse the repository at this point in the history
  115. vcsim: Add RUN.env flag to inject environment variables to container-…

    …backed VM
    BrianMMcClain authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    6959b9a View commit details
    Browse the repository at this point in the history
  116. vcsim: set StandbyMode default to "none"

    according Enum HostStandbyMode(vim.HostSystem.StandbyMode), StandByMode
    should not be empty
    xarem authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    5c40646 View commit details
    Browse the repository at this point in the history
  117. Remove client request log from debug tracing

    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    5f9213e View commit details
    Browse the repository at this point in the history
  118. add cnssyncdatastore API

    sashrith authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8c3ee71 View commit details
    Browse the repository at this point in the history
  119. fix: share http.Transport with service clients

    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ba26133 View commit details
    Browse the repository at this point in the history
  120. fix: avoid modifying client transport outside of NewClient

    PR vmware#3161 introduced a race when sharing http transport between
    soap client and service clients
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    149c0ce View commit details
    Browse the repository at this point in the history
  121. fix: Fix the gorelease

    lubronzhan authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    94b36c0 View commit details
    Browse the repository at this point in the history
  122. govc: Add CLI device protocol support for vm.network.add

    Closes: vmware#3167
    lubronzhan authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    b231479 View commit details
    Browse the repository at this point in the history
  123. vcsim: apply PCI UnitNumber offset of 7 for ethernet

    BrianMMcClain authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    2502807 View commit details
    Browse the repository at this point in the history
  124. add opentelemetry collector contrib as notable user

    schmikei authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    51a6163 View commit details
    Browse the repository at this point in the history
  125. fix: check the error chain when validating if it's x509 error

    Closes: vmware#3174
    lubronzhan authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    5d4e4d8 View commit details
    Browse the repository at this point in the history
  126. Allow picking datastore upload URL scheme by env

    When constructing the datastore URL using a *soap.Client, there may be
    edge cases where VC and ESX schemes differ. Allow using an environment
    variable to override this instead of assuming homogeneous schemes.
    
    - Update the vcsim datastore bats test to test this.
    - Also updated the same bats test to use vcsim instead of just ESX for
      datastore upload.
    - Verified that a client using HTTP to VC and HTTPS to ESX worked as
      expected during datastore file upload.
    mayankbh authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    5133806 View commit details
    Browse the repository at this point in the history
  127. build: quote golang version in release file to workaround issue in gi…

    …thub action
    
    Close vmware#3179
    lubronzhan authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    31b7d63 View commit details
    Browse the repository at this point in the history
  128. fix: Update some goreleaser deprecated fields

    lubronzhan authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    7a73330 View commit details
    Browse the repository at this point in the history
  129. chore: Dockerfile & steps for generating types

    This patch introduces a Dockerfile for generating the
    vim types. The image should be cross-arch compatible.
    
    This patch also enables "gen.sh" to automatically update
    the VIM version in "vim25/client.go".
    
    This patch also ensures "gen/rbvmomi/vmodl.db" is downloaded
    if it does not already exist when generating types.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    cc9fd1b View commit details
    Browse the repository at this point in the history
  130. vcsim: add lookup.EndpointURL tests

    - Add ssoadmin to lookup simulator
    
    - Add tests validating sts/ssoadmin use of lookup.EndpointURL
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    fa5aee7 View commit details
    Browse the repository at this point in the history
  131. Bypass lookup svc for STS and SSOadmin clients

    - For local clients on vCenter, lookup service can be omitted and local
      Envoy processes can be used instead, along with 'system-' prefixed
      variants of SSOAdmin/STS. This avoids the need to discover the
      vCenter SSO domain and avoids an extra round trip.
    
    - Also extends simulator to allow aliasing the same SDK to multiple
      paths. Moves vimService, ssoadmin, STS to this model.
    
    - Using env vars to allow testing this with the simulator in unit tests,
      but with a sensible defaults (localhost/1080).
    
    - Added unit tests for this path (simulate lookupsvc returning the wrong
      URL and asserting that the STS/ssoadmin clients still function)
    
    - Moved the lookup service simulator breaking logic to
      lookup/simulator.go so it's usable elsewhere.
    
    - Tweaked the simulator.Test/Run() methods to not always set up TLS
      config (since we use HTTP for the ssoadmin/sts client)
    
    - Moved sts/client_test.go to the sts_test package to avoid an import
      cycle (sts/simulator -> sts -> sts/simulator via test code)
    mayankbh authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ba86410 View commit details
    Browse the repository at this point in the history
  132. vcsim: add PerformanceManager counter values

    kbrock authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ebf7c1d View commit details
    Browse the repository at this point in the history
  133. remove bad spacing in new pull request template

    kbrock authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    2bfda00 View commit details
    Browse the repository at this point in the history
  134. vcsim: Fix RefreshDatastore to return a valid response

    Closes: vmware#3198
    dekp authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    5090e85 View commit details
    Browse the repository at this point in the history
  135. vcsim: untangle container/VM to allow reuse of container logic for hosts

    Refactors the container logic out of the simulator VM file so it can be
    used for both VM and host container backings.
    
    The following file structure is now in place:
    * container.go - wraps docker operation execs
    * container_virtual_machine.go - orchestration of containers for VMs
    * container_host_system.go - orchestration of containers for Hosts
    * container_xxx_test.go - test for container backed VMs/Hosts
    
    Add CGO_ENABLED=1 to test command with -race
    hickeng authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    97a493c View commit details
    Browse the repository at this point in the history
  136. vcsim: support container backing for hosts

    This adds support for backing a host with a container in a similar
    manner to how we back VMs with containers.
    
    Hosts do not have the VM ExtraConfig mechanism, and "creation" of a
    host is more "register the existance of" vs VMs that are actively
    constructed from the provided spec. As such, this uses the advanced
    options mechanism provided by the per-host Option Manager instead
    of ExtraConfig, but following the same "RUN.container" key/value
    approach for defining a container backing.
    
    The created container for a host has the following volumes defined:
    * bootbank (read-only)
    * altbootbank (read-only)
    * OS-DATA (read-write)
    * datastore1 (read-write)
    
    The volumes have suitably formed UUIDs, are mounted under
    /vmfs/volumes, and have symlinked pretty names.
    
    The volumes are associated with the host via labels, allowing the
    use of filtered queries to retrieve volumes associated with a given
    host.
    
    All docker invocation is kept in container.go and out of the
    container_xxx.go files. Not clear this is a fundamental benefit, but
    should make it easier if we ever want to support remote docker hosts.
    hickeng authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c92c27f View commit details
    Browse the repository at this point in the history
  137. vcsim: per-host OptionManager instances and differentiated roles

    Creates an OptionManager instance per-host, with valued seeded from the
    ESX template but not directly referencing it, ie. template changes will
    not reflect into existing OptionManager instances.
    OptionManager Query and Update methods work as expected.
    
    Changes made via OptionManager are reflected into host.Config.Options
    array, but it's a unidirectional reflection. This is done to match
    infered behaviour of ESX.
    
    There are two OptionManager instances for ESX (and I assume for VC),
    For ESX they are found at:
    * ServiceContent.setting
    * ConfigManager.advancedOptions
    
    The settings for ESX are empty, and the template had named the adv
    opts as settings. This adds an empty Setting array in the templates to
    clearly differentiate which set of BaseOptionValues is used to populate
    which OptionManager instance.
    
    Follow up required for:
    * VC to determine what the contents of adv opts should be.
    * whether HostConfigInfo.Options is adv opts, or combined set
    hickeng authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    40fa470 View commit details
    Browse the repository at this point in the history
  138. vcsim: create underlay network for pNICs in container-backed hosts

    Connects sim-hosts to bridges as specified in their config.
    The bridges to use for a given pNIC are expressed in the advanced
    options using the following pattern (example for pNIC 0):
    	RUN.underlay.vmnic0=vcsim-mgmt-underlay
    
    This uses an existing bridge or creates a new one as
    needed.
    
    If a host has a container backing, all pNICs defined in the host
    template are discarded and new pNICs are created, 1 per underlay
    name provided to simulator.HostSystem.configureContainerBacking.
    This was the only sane way I found to indicate which bridges a
    host should be connected to.
    
    The IP assigned to the container is reflected into the various
    host.Config structures associated with the vmknic, eg.
    VirtualNicManagerInfo
    
    The simulator.HostSystem.getNetConfigInterface method is prvoided to
    allow a caller to retrieve all the various network entities associated
    with a NetConfig binding, eg. "management", "vmotion".
    
    Remove use of errors.Join to maintain support for older Go versions.
    
    Known issues:
    * podman volume ls filters act as OR instead of AND which results in
      all volumes being deleted any time a single host is removed. Issue
      opened and fixed in podman main.
    hickeng authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f4e6e3f View commit details
    Browse the repository at this point in the history
  139. vcsim: container backing respects changes via reconfigure

    If "RUN.container" is added or removed on an existing VM, that change
    is applied immediately if the VM is currently powered on.
    
    Modifications to the value of the key do not have an effect unless the
    continue needs to be recreated for some reason.
    
    Switches to Go templates for formating docker command output
    
    Includes additional error logging detail
    hickeng authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    4b388b1 View commit details
    Browse the repository at this point in the history
  140. vcsim: use docker event for efficient monitoring

    Makes use of the docker events stream to trigger inspect operations
    against containers where waiting for things such as IPs.
    
    Corrects prior failure to stop the async container watch when the
    container was removed.
    
    Updates to locking to avoid race warnings.
    
    Updates vcsim.bats to look for a volume with `--dmi` suffix instead
    of a volume with the plain container name.
    hickeng authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    92d5d59 View commit details
    Browse the repository at this point in the history
  141. vcsim: add interactive debug github action stage

    Adds a stage to the github actions pipeline that provides an ssh server
    that allows interactive login to the environment. This only triggers on
    failure.
    
    The reason for adding this is due to repeated failures to find
    functional arguements for the specific docker version present. Quirks
    around the format parameter values specifically.
    
    This is done using the tmate action:
    https://github.com/mxschmitt/action-tmate
    
    Corrects boilerplate
    hickeng authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    990af64 View commit details
    Browse the repository at this point in the history
  142. Address review comments

    I expect to squash this into an earlier commit once it passes tests
    vcsim: support container backing for hosts
    hickeng authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    cf15e2f View commit details
    Browse the repository at this point in the history
  143. Trim leading slash on soap path

    rikatz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    280d5c6 View commit details
    Browse the repository at this point in the history
  144. govc: add -file flag for cluster.module.rm

    chrischdi authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    223fe96 View commit details
    Browse the repository at this point in the history
  145. build(deps): bump github.com/google/uuid from 1.3.0 to 1.3.1

    Bumps [github.com/google/uuid](https://github.com/google/uuid) from 1.3.0 to 1.3.1.
    - [Release notes](https://github.com/google/uuid/releases)
    - [Changelog](https://github.com/google/uuid/blob/master/CHANGELOG.md)
    - [Commits](google/uuid@v1.3.0...v1.3.1)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/google/uuid
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    0fe571f View commit details
    Browse the repository at this point in the history
  146. govc/library: fix dropped error

    alrs authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    e637f3a View commit details
    Browse the repository at this point in the history
  147. govc: Fix memory aliasing in for loop (gosec G601)

    Fix gosec G601 "Implicit memory aliasing in for loop" error
    by reassigning the iteration variable inside the loop.
    
    refs vmwareGH-2243
    refs vmwareGH-2269
    atc0005 authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    7f17e39 View commit details
    Browse the repository at this point in the history
  148. fix: govc datacenter.info VM count with multiple DCs

    rikatz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    d6c1530 View commit details
    Browse the repository at this point in the history
  149. vcsim: Introduce separation btw new service instance & infra creation

    vdsvm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    68d1eb3 View commit details
    Browse the repository at this point in the history
  150. build(deps): bump actions/checkout from 3 to 4

    Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@v3...v4)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    955edb2 View commit details
    Browse the repository at this point in the history
  151. fix: govc vm.clone failure when using 'cluster' option

    Closes vmware#3208
    Signed-off-by: Erik Lund <info@erikjensen.it>
    ErikLundJensen authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    58dbe84 View commit details
    Browse the repository at this point in the history
  152. govc: Command to print device/backings model as tree

    This patch introduces the `govc device.model.tree [-backings]`
    command for printing either the VirtualDevice or
    VirtualDeviceBackingInfo type hierarchy as a tree.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    7a25a9a View commit details
    Browse the repository at this point in the history
  153. api: Add SDK support for VM data sets

    Data sets provide a mechanism to share data between the vSphere
    management layer and the VM guest OS:
    https://core.vmware.com/resource/vsphere-datasets
    
    Closes: vmware#3050
    dekp authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    35cd191 View commit details
    Browse the repository at this point in the history
  154. vcsim: Add simulator support for VM data sets

    Store data sets as a field in `simulator.VirtualMachine`, because a data set
    can be copied during a VM clone or snapshot
    (see dataset.CreateSpec.OmitFromSnapshotAndClone).
    Clone and snapshot are implemented in simulator.VirtualMachine, so it seems
    more natural to keep data sets in simulator.VirtualMachine and access them from
    the code in the vapi simulator.
    
    Extract the simulation code for REST APIs under `/api/vcenter/vm` into its own
    sub-simulator:
    Data set request paths look like this:
    `/api/vcenter/vm/{moid}/data-sets/{id}`
    Currently vcsim routes API requests via the standard http.ServeMux.
    However, http.ServeMux does not support placeholders in the middle of the URL
    path (e.g. VM moid, data set id).
    So create a separate sub-simulator for everything under `/api/vcenter/vm`.
    At the moment it contains only delete VM
    (see vmware#1770)
    and the data sets API.
    
    Inside the new sub-simulator for `/api/vcenter/vm`, API requests are routed via
    analyzing the URL path segment by segment:
    As mentioned above, http.ServeMux cannot handle placeholders.
    Here I have done routing in code.
    An alternative would be to use a third-party library for request routing like
    `go-chi` or even a home-grown regex table or a radix tree.
    Potentially the main vapi simulator could allow sub-simulators to register for
    paths with placeholders.
    See also notes at:
    https://github.com/vmware/govmomi/blob/e7aac6ad473846f6a1f5bf10c524ac5a8f93022d/vapi/simulator/simulator.go#L2084
    
    In order to get a lock on a `simulator.VirtualMachine`,
    had to create a `simulator.Context` similar to `SpoofContext()`
    but using the `simulator.Registry` received during initialization.
    
    Closes: vmware#3050
    dekp authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    a2649ef View commit details
    Browse the repository at this point in the history
  155. govc: Add CLI support for VM data sets

    Closes: vmware#3050
    dekp authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    6409001 View commit details
    Browse the repository at this point in the history
  156. api: Type/field comments for data structures; API versions

    This patch enables the addition of code comments for generated
    types and their fields by parsing the OpenAPI specification for
    the vSphere JSON API endpoint.
    
    This patch also adds support for tracking the minimum API version
    for a type, enum, and enum value.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    1de779b View commit details
    Browse the repository at this point in the history
  157. api: Prep to update types to vSphere 8.0U1c GA

    This patch updates the gen.sh file with the information necessary to
    generate the types for vSphere 8.0U1c GA.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    b44a02e View commit details
    Browse the repository at this point in the history
  158. api: Update generated types to vSphere 8.0U1c GA

    This patch updates the generated types to vSphere 8.0U1c GA.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8312fa9 View commit details
    Browse the repository at this point in the history
  159. build(deps): bump goreleaser/goreleaser-action from 4 to 5

    Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4 to 5.
    - [Release notes](https://github.com/goreleaser/goreleaser-action/releases)
    - [Commits](goreleaser/goreleaser-action@v4...v5)
    
    ---
    updated-dependencies:
    - dependency-name: goreleaser/goreleaser-action
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    833ecf5 View commit details
    Browse the repository at this point in the history
  160. Use Envoy sidecar for guest and datastore file transfer.

    - vCenter has a local Envoy process exposed over a Unix socket dedicated
      for host connectivity.
    - During requests that involve traffic to ESX, when the envoy sidecar is
      in use (localhost:1080) in the VC client, leverage the envoy host
      gateway.
    - Avoid keeping the connection alive since we're only using it for one
      request to the host. (ie. no connection pool to the host(s) being
      maintained here)
    
    Testing:
    
    With a Go based service using localhost:1080, used iptables to block
    outbound traffic to 443 (and thereby prevent ESX access), verified that
    guest file transfer, datastore file upload continued to work.
    
    Added unit test to verify socket creation.
    
    I think it would make sense to enhance vcsim to support this host
    gateway socket, but from what I could tell, the existing vcsim tests for
    things like datastore upload only run vcsim with an ESX - I could not
    find anything in place to simulate both VC and ESX.
    mayankbh authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    b3a9d8e View commit details
    Browse the repository at this point in the history
  161. api: Prep to update types to vSphere 8.0U2 GA

    This patch updates the gen.sh file with the information necessary to
    generate the types for vSphere 8.0U2 GA.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    e4c309c View commit details
    Browse the repository at this point in the history
  162. api: Update generated types to vSphere 8.0U2 GA

    This patch updates the generated types to vSphere 8.0U2 GA.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c70a474 View commit details
    Browse the repository at this point in the history
  163. api: Fix errors w 8.0U2 GA update

    This patch addresses a build error after the update to 8.0U2 GA.
    The VSLM client was using an invalid API syntax. Additionally,
    there was a fix for the change from the "mo" field tag to using
    "json" instead.
    akutz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    7c97b73 View commit details
    Browse the repository at this point in the history
  164. chore: Update version.go for v0.31.0

    Signed-off-by: GitHub Action <41898282+github-actions[bot]@users.noreply.github.com>
    github-actions[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    358b1f3 View commit details
    Browse the repository at this point in the history
  165. docs: update govc jq examples with correct case

    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    d49c4c0 View commit details
    Browse the repository at this point in the history
  166. emacs: update for v0.31.0 release

    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f1e6fc1 View commit details
    Browse the repository at this point in the history
  167. fix: case insensitive govc import.ova PropertyMapping

    v0.31.0 changed the json case of generated types, which breaks existing PropertyMapping used in the -options input spec
    
    Fixes vmware#3245
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    edfdeb6 View commit details
    Browse the repository at this point in the history
  168. govc: camelCase json output

    PR vmware#3007 added camelCase json tags for generated types
    BREAKING: This change adds camelCase (lower-case 1st character) json tags for govc types
    
    Fixes vmware#3243
    Fixes vmware#3242
    Fixes vmware#3241
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    74165ab View commit details
    Browse the repository at this point in the history
  169. vcsim: EnvironmentBrowser improvements

    vcsim: add EnvironmentBrowser methods and record/replay support
    
    api: add object.EnvironmentBrowser helper methods
    
    govc: add vm.option.ls, vm.target.info and vm.target.cap.ls commands
    
    BREAKING: removed object.VirtualMachine.QueryConfigTarget method
    - Use object.VirtualMachine.EnvironmentBrowser().QueryConfigTarget instead
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    0200e09 View commit details
    Browse the repository at this point in the history
  170. vcsim: set HostSystem.Config.Host

    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    80257c4 View commit details
    Browse the repository at this point in the history
  171. api: disable HTTP Keep-Alive for direct ESX connections

    guest file transfer and ticketed datastore file transfer use direct ESX connections.
    The connection should be only be used for a single request, ensure this by disabling client side.
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    0d039d4 View commit details
    Browse the repository at this point in the history
  172. examples: add ListView example for waiting on updates to tasks

    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    40c735c View commit details
    Browse the repository at this point in the history
  173. chore: remove refs to deprecated io/ioutil

    testwill authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f317b5e View commit details
    Browse the repository at this point in the history
  174. vcsim: Remove extra devices in OVF Deploy w/ ConfigSpec

    The ConfigSpec returned by CreateImportSpec() will include devices from
    the OVF but since the simulator impl just reconfigures the VM with the
    user provided ConfigSpec, those default devices won't be removed.  In VM
    Operator, likely the only user of this API w/ the ConfigSpec param, this
    would result in an extra Reconfigure to remove the unexpected devices.
    However, I'd like to be able to assert that a just-created VM matches
    the expected config.
    
    It is a easier to just skip the EthCards instead of including all the
    disk and disk controllers. A later improvement would be to merge the two
    ConfigSpecs so the Reconfigure is not needed but neither is a huge deal
    for the simulator.
    bryanv authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    1d097ab View commit details
    Browse the repository at this point in the history
  175. build(deps): bump chuhlomin/render-template from 1.7 to 1.8

    Bumps [chuhlomin/render-template](https://github.com/chuhlomin/render-template) from 1.7 to 1.8.
    - [Release notes](https://github.com/chuhlomin/render-template/releases)
    - [Commits](chuhlomin/render-template@v1.7...v1.8)
    
    ---
    updated-dependencies:
    - dependency-name: chuhlomin/render-template
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    cc397e3 View commit details
    Browse the repository at this point in the history
  176. govc: add option to enable hidden properties in import.{spec,ova}

    vcsim: ResourcePool.ImportVApp improvements
    - Run within an internal Task as real vCenter does
    - Set VirtualMachineImportSpec.VAppConfig in CreateImportSpec
    - Propagate VAppConfig to VirtualMachine (config.vAppConfig)
    - Validate userConfigurable=false properties
    
    Fixes vmware#3111
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c093f3b View commit details
    Browse the repository at this point in the history
  177. build(deps): bump github.com/google/go-cmp from 0.5.9 to 0.6.0

    Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.9 to 0.6.0.
    - [Release notes](https://github.com/google/go-cmp/releases)
    - [Commits](google/go-cmp@v0.5.9...v0.6.0)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/google/go-cmp
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    7343a2b View commit details
    Browse the repository at this point in the history
  178. vcsim: fix ModifyListView to return unresolved references

    BREAKING: api: view.ListView.{Add,Remove,Reset} methods now return unresolved references
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    d74f8e3 View commit details
    Browse the repository at this point in the history
  179. vapi: add support for OperationID header

    soap.Client sends OperationID as part of the soap body header.
    vapi uses the `X-Request-ID` http header.
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f6d6b27 View commit details
    Browse the repository at this point in the history
  180. govc: add cluster.change '-ha-admission-control-enabled' flag

    vcsim: apply DasConfig + DrsConfig in ReconfigureComputResource_Task
    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    050831d View commit details
    Browse the repository at this point in the history
  181. vcsim: Handle prepare guest operations when svm is nil

    The existing code would panic due to not checking for svm being nil and
    then immediately accessing a field to check power state.
    mayankbh authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    6bfc735 View commit details
    Browse the repository at this point in the history
  182. Add functionality for checking whether the provided thumbprint is kno…

    …wn to the soap client
    HakanSunay authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    52da3a4 View commit details
    Browse the repository at this point in the history
  183. Add additional PBM methods

    rikatz authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    74c7ee2 View commit details
    Browse the repository at this point in the history
  184. build(deps): bump github.com/google/uuid from 1.3.1 to 1.4.0

    Bumps [github.com/google/uuid](https://github.com/google/uuid) from 1.3.1 to 1.4.0.
    - [Release notes](https://github.com/google/uuid/releases)
    - [Changelog](https://github.com/google/uuid/blob/master/CHANGELOG.md)
    - [Commits](google/uuid@v1.3.1...v1.4.0)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/google/uuid
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    6ef5865 View commit details
    Browse the repository at this point in the history
  185. api: add Content Library update session file APIs

    dougm authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    0c5f1b1 View commit details
    Browse the repository at this point in the history
  186. vcsim: Fix PropertyCollector to handle empty property

    Closes: vmware#3275
    Signed-off-by: syuparn <s.hello.spagetti@gmail.com>
    Syuparn authored and Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3fd42aa View commit details
    Browse the repository at this point in the history
  187. Add KMIP support in VC sim

    Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c366b98 View commit details
    Browse the repository at this point in the history
  188. Add KMS support

    Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8d29015 View commit details
    Browse the repository at this point in the history
  189. Merge branch 'pjiandani/add-kmip-support' of https://github.com/priya…

    …nka19-98/govmomi into pjiandani/add-kmip-support
    Priyanka Jiandani committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    a0a62bc View commit details
    Browse the repository at this point in the history
  190. Configuration menu
    Copy the full SHA
    e0fd09c View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. replaced print with log

    Sindhusha-p committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    f2f0edf View commit details
    Browse the repository at this point in the history