Conversation
3aaa537 to
25238be
Compare
25238be to
b180ed6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For better Kotlin interop, it would be good to allow returning proper deserialization/binding errors, while trying to use non-nullable fields. Because simple (
Int,Longetc.) non-nullable fields are represented in bytecode as primitives, following exceptions were identified at the moment.KotlinInvalidNullException(subclass ofInvalidNullException) if trying to deserialize to non-nullable field.MismatchedInputExceptionif trying to use invalid value for a primitive (like a"text"for anint).Decided to use
Type mismatcherror instead ofValidation failedas it is better suited and in fact does not involve validation - this is a deserialization failure.Edit: changes were applied to #93, so primitive deserialization errors are fixed in
1.2.xversion as well. This PR includes only tests for Kotlin interop.