Skip to content

Conversation

@karm-patel
Copy link
Collaborator

Decryption

  • Resolve bug in upload_urls_to_firestore()
  • Add create_firestore_db() in url_utils to create db instance of firestore
  • Resolve initialize_app(cred) bug in create_firestore_db()

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2273893177

  • 4 of 14 (28.57%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 23.762%

Changes Missing Coverage Covered Lines Changed/Added Lines %
probml_utils/url_utils.py 4 14 28.57%
Files with Coverage Reduction New Missed Lines %
probml_utils/url_utils.py 2 42.98%
Totals Coverage Status
Change from base Build 2266015389: 0.09%
Covered Lines: 288
Relevant Lines: 1212

💛 - Coveralls

@patel-zeel patel-zeel merged commit b130363 into probml:main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants