Skip to content

[FEAT] Handle bpmn-visualization load errors in examples#286

Merged
tbouffard merged 6 commits into
masterfrom
281-manage_bpmn-visu_load_errors
Jan 24, 2022
Merged

[FEAT] Handle bpmn-visualization load errors in examples#286
tbouffard merged 6 commits into
masterfrom
281-manage_bpmn-visu_load_errors

Conversation

@tbouffard
Copy link
Copy Markdown
Member

@tbouffard tbouffard commented Jan 18, 2022

Update the examples loading external BPMN source

  • bpmn-vendors comparison: open a window alert as when using bpmn-js
  • load local diagram: open a window alert
  • load remote diagram: display BPMN load success or error in a dedicated
    status area

In addition, for the 'load remote diagram' example

  • round fetch and load on Chromium
  • display duration in the status area on fetch ko

closes #281

Implementation notes

This Pull Request initially includes a bpmn-visualization development version which did no longer open a window alert. A revert commit is included in the later changelog as a released version of bpmn-visualization (0.21.3) is now available with this change.

Live environment of examples

https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/281-manage_bpmn-visu_load_errors/examples/index.html

Design change in the 'load remote diagram' example

Show the 'load status' area

bpmn-remote-load_status.mp4

Duration on fetch ko
bpmn-remote_fetch_ko_display_duration

@tbouffard tbouffard added enhancement New feature or request depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first labels Jan 18, 2022
@tbouffard tbouffard force-pushed the 281-manage_bpmn-visu_load_errors branch 2 times, most recently from b5f18e8 to 2051985 Compare January 18, 2022 15:29
@tbouffard tbouffard removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Jan 18, 2022
@tbouffard
Copy link
Copy Markdown
Member Author

tbouffard commented Jan 18, 2022

@csouchet we can change the color of the background for a sucessfull load. What do you prefer?
We can also introduce our own toast-load class to use a dedicated background color

2051985 without the toast-primary class
image image

@tbouffard tbouffard force-pushed the 281-manage_bpmn-visu_load_errors branch from 2051985 to ae73158 Compare January 24, 2022 11:04
@tbouffard tbouffard added the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Jan 24, 2022
Use it in examples that need to manage BPMN load errors
  - bpmn-js
  - kie-editors-standalone
  - load local diagram
  - load remote diagram
Update the examples loading external BPMN source
  - bpmn-vendors comparison: open a window alert as when using bpmn-js
  - load local diagram: open a window alert
  - load remote diagram: display BPMN load success or error in a dedicated
  status area
@tbouffard tbouffard force-pushed the 281-manage_bpmn-visu_load_errors branch from ae73158 to 78c8e4d Compare January 24, 2022 11:09
@tbouffard tbouffard removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Jan 24, 2022
@tbouffard tbouffard marked this pull request as ready for review January 24, 2022 11:11
@csouchet
Copy link
Copy Markdown
Contributor

csouchet commented Jan 24, 2022

@csouchet we can change the color of the background for a sucessfull load. What do you prefer? We can also introduce our own toast-load class to use a dedicated background color
2051985 without the toast-primary class
image image

@tbouffard

I don't like the primary color for the Ok message. There is too many elements with this color.

ℹ️ Also, generally, the container message is used for the error and not when it's ok.
I'm not sure that is very useful to have the 2 OK messages when all is well 😕

@tbouffard
Copy link
Copy Markdown
Member Author

Final decision: keep the 2 status area for now (we need to merge this PR to handle load errors. Improvement can be done later). The load status is filled in green on success.

image

@tbouffard tbouffard merged commit 3e90d27 into master Jan 24, 2022
@tbouffard tbouffard deleted the 281-manage_bpmn-visu_load_errors branch January 24, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] Manage BPMN load errors in examples

2 participants