[FEAT] Handle bpmn-visualization load errors in examples#286
Merged
Conversation
b5f18e8 to
2051985
Compare
csouchet
approved these changes
Jan 18, 2022
Member
Author
2051985 to
ae73158
Compare
Use it in examples that need to manage BPMN load errors - bpmn-js - kie-editors-standalone - load local diagram - load remote diagram
Update the examples loading external BPMN source - bpmn-vendors comparison: open a window alert as when using bpmn-js - load local diagram: open a window alert - load remote diagram: display BPMN load success or error in a dedicated status area
This reverts commit 305bb8c.
ae73158 to
78c8e4d
Compare
Contributor
I don't like the primary color for the Ok message. There is too many elements with this color. ℹ️ Also, generally, the container message is used for the error and not when it's ok. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Update the examples loading external BPMN source
status area
In addition, for the 'load remote diagram' example
closes #281
Implementation notes
This Pull Request initially includes a bpmn-visualization development version which did no longer open a window alert. A revert commit is included in the later changelog as a released version of bpmn-visualization (0.21.3) is now available with this change.
Live environment of examples
https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/281-manage_bpmn-visu_load_errors/examples/index.html
Design change in the 'load remote diagram' example
Show the 'load status' area
bpmn-remote-load_status.mp4
Duration on fetch ko
