Skip to content

[FEAT] Improve types support in the ViteJS TS project#292

Merged
tbouffard merged 3 commits into
masterfrom
feat/improve_ts_projects_config
Feb 16, 2022
Merged

[FEAT] Improve types support in the ViteJS TS project#292
tbouffard merged 3 commits into
masterfrom
feat/improve_ts_projects_config

Conversation

@tbouffard
Copy link
Copy Markdown
Member

@tbouffard tbouffard commented Feb 15, 2022

Add typed-mxgraph as devDependencies and explain an alternative way without this dependency.

covers process-analytics/bpmn-visualization-js#1808
relates to process-analytics/bpmn-visualization-js#1814: the current PR has been used to test the types provided by the bpmn-visualization PR

Add typed-mxgraph as devDependencies and explain an alternative way without this
dependency.
@tbouffard tbouffard added the enhancement New feature or request label Feb 15, 2022
@tbouffard tbouffard requested review from a team and csouchet and removed request for a team February 15, 2022 15:34
@tbouffard
Copy link
Copy Markdown
Member Author

The vitejs project is currently failing because I set skipLibCheck to false. Once process-analytics/bpmn-visualization-js#1808 testing is completed, we will restore the skipLibCheck value to make the project succeed.
We will set skipLibCheck to true once a new bpmn-visualization version including the fix will be available.

@tbouffard
Copy link
Copy Markdown
Member Author

Testing of process-analytics/bpmn-visualization-js#1808 testing is completed, so I have restored the skipLibCheck value.

@tbouffard tbouffard changed the title [FEAT] Improve types support in the TS project managed with ViteJS [FEAT] Improve types support in the ViteJS TS project Feb 16, 2022
@tbouffard tbouffard merged commit f736618 into master Feb 16, 2022
@tbouffard tbouffard deleted the feat/improve_ts_projects_config branch February 16, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants