Skip to content

[REFACTOR] Use the new Navigation API to perform fit#345

Merged
tbouffard merged 2 commits into
masterfrom
refactor/use_new_navigation_object_to_fit
May 30, 2022
Merged

[REFACTOR] Use the new Navigation API to perform fit#345
tbouffard merged 2 commits into
masterfrom
refactor/use_new_navigation_object_to_fit

Conversation

@tbouffard
Copy link
Copy Markdown
Member

@tbouffard tbouffard commented May 27, 2022

In bpmn-visualization@0.24.0, the oldest fit API is deprecated so prepare the future.

Requires process-analytics/bpmn-visualization-js#1988 and a new bpmn-visualization release.

Live environment of examples

https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/refactor/use_new_navigation_object_to_fit/examples/index.html

In bpmn-visualization@0.24.0, the oldest `fit` API is deprecated so prepare the future.
@tbouffard tbouffard added the refactoring Code refactoring label May 27, 2022
@tbouffard tbouffard changed the title [REFACTOR] use the new Navigation API to perform fit [REFACTOR] Use the new Navigation API to perform fit May 27, 2022
@tbouffard
Copy link
Copy Markdown
Member Author

#347 has been merged, so this should work now.

@tbouffard tbouffard marked this pull request as ready for review May 30, 2022 09:30
@tbouffard
Copy link
Copy Markdown
Member Author

✔️ Tested on statically.io

@tbouffard tbouffard merged commit 5648236 into master May 30, 2022
@tbouffard tbouffard deleted the refactor/use_new_navigation_object_to_fit branch May 30, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant