Skip to content

[FEAT] Add the new "2022" theme in the Hacktoberfest demo#400

Merged
tbouffard merged 6 commits into
masterfrom
374-hacktoberfest_demo_theme_2022
Sep 22, 2022
Merged

[FEAT] Add the new "2022" theme in the Hacktoberfest demo#400
tbouffard merged 6 commits into
masterfrom
374-hacktoberfest_demo_theme_2022

Conversation

@tbouffard
Copy link
Copy Markdown
Member

@tbouffard tbouffard commented Sep 21, 2022

For the 1st time, use a dedicated font to better match the brand guidelines.

Improve the label bounds in the BPMN diagram, especially for the Hacktoberfest 2022 theme. Use the right wording for the lib name: "BPMN Visualization" --> "bpmn-visualization"

General improvements in theme management

  • let configure the default font size
  • remove duplication when applying the mxgraph styles and better manage default values
  • improve the page styles
    • display nothing prior the page is fully loaded. Previously several titles were displayed while loading.
    • do not duplicate styles and use CSS class instead of inline styles

covers #374

Live environment of examples

https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/d5326c1/demo/hacktoberfest-custom-themes/index.html

Remaining Tasks

  • Review colors and gradients
  • Clean remaining comments and TODO

Initial theme proposed in commit b4bd015

dark light
hacktoberfest_dark_theme_v02 hacktoberfest_light_theme_v02

For the 1st time, use a dedicated font to better match the brand guidelines.

Improve the label bounds in the BPMN diagram, especially for the Hacktoberfest 2022 theme.
Use the right wording for the lib name: "BPMN Visualization" --> "bpmn-visualization"

General improvements in theme management
  - let configure the default font size
  - remove duplication when applying the mxgraph styles and better manage default values
@tbouffard tbouffard added the enhancement New feature or request label Sep 21, 2022
@tbouffard tbouffard changed the title [FEAT] Add a new theme for Hacktoberfest 2022 [FEAT] Add the new "2022" theme in the Hacktoberfest demo Sep 21, 2022
@assynour
Copy link
Copy Markdown

I really like the light theme 👌
Minor comment: is the font size the same as previous years? it seems smaller. I wonder if it's possible to increase it a bit 😣

@tbouffard
Copy link
Copy Markdown
Member Author

I really like the light theme ok_hand Minor comment: is the font size the same as previous years? it seems smaller. I wonder if it's possible to increase it a bit persevere

Yes the size is smaller, it is currently set to 9 (the default value is 11). I have tried to used larger values but the label went outside the shapes. I will do some extra test to increase the size.

display nothing prior the page is fully loaded. Previously several titles were displayed while loading.
do not duplicate and inline style
@tbouffard
Copy link
Copy Markdown
Member Author

@tbouffard tbouffard marked this pull request as ready for review September 22, 2022 12:46
@assynour
Copy link
Copy Markdown

Yes, I think it's better. I opened both versions on my small laptop screen and 3a0367f is more readable

@tbouffard tbouffard merged commit 62a27db into master Sep 22, 2022
@tbouffard tbouffard deleted the 374-hacktoberfest_demo_theme_2022 branch September 22, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants