[FEAT] Simplify integration of bpmn-visualization in TS projects#405
Merged
tbouffard merged 13 commits intoOct 3, 2022
Conversation
tbouffard
added
enhancement
Remove the additional TypeScript configuration that was needed prior version 0.27.0. The README has been updated to warn TS user that use older version. The parcel project now directly calls the mxGraph code in addition to the vite project. This provides more test for this use case and better validated the npm package.
tbouffard
force-pushed
the
feat/use_bpmn-visualization_simplified_ts_config
branch
from
26f7a0e to
28d7046
Compare
csouchet
approved these changes
Sep 29, 2022
Member
Author
|
Update after using bpmn-visualization@0.27.0. See process-analytics/bpmn-visualization-js#2258 |
tbouffard
removed
the
depends on another PR ⚠️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the additional TypeScript configuration that was needed prior version 0.27.0. The README has been updated to warn
TS user that use older version.
The parcel project now directly calls the mxGraph code in addition to the vite project. This provides more test for this
use case and better validated the npm package.
The GitHub workflow now builds the projects with both the latest released version of bpmn-visualization and the master branch.
This provides more non regression tests.
Local tests
Build bpmn-visualization npm package with branch of process-analytics/bpmn-visualization-js#2258:
npm packUse it in projects:
npm install ../../../bpmn-visualization-js/bpmn-visualization-0.26.2-post.tgz(assuming the examples and lib are stored in the same parent directory)