Wayland support #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tychedelia
requested changes
Nov 24, 2025
Member
tychedelia
left a comment
tychedelia
left a comment
There was a problem hiding this comment.
Looks great! Just minor comment on use of unsafe.
renderer/src/lib.rs
Outdated
| let (raw_window_handle, raw_display_handle) = { | ||
| use raw_window_handle::{WaylandDisplayHandle, WaylandWindowHandle}; | ||
|
|
||
| let window_handle_ptr = unsafe { NonNull::new_unchecked(window_handle as *mut c_void) }; |
Member
There was a problem hiding this comment.
We should only use the unchecked variants in situations where we control the provenance of the pointer, or at the least document the invariant in the safety information for this function. Here, I think we can do the lazy thing that I do above which is NonNull::new(ptr).unwrap()) which guarantees we'll at least panic if the caller passes us a null ptr (we probably should be returning HandleError).
Contributor
Author
There was a problem hiding this comment.
Amazing! Just addressed the feedback. I am returning HandleError now
tychedelia
approved these changes
Nov 25, 2025
tychedelia
added a commit
that referenced
this pull request
Nov 25, 2025
- Implement Wayland surface creation - Add checked pointer unwrapping and error handling for null pointers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a patch from [#1337 in Processing4](https://github.com/processing/processing4/pull/