Skip to content

[#1953] Separate Console and Editor font sizes #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anderoonies wants to merge 1 commit into from
Closed

[#1953] Separate Console and Editor font sizes #1983

anderoonies wants to merge 1 commit into from

Conversation

@anderoonies
Copy link

@anderoonies anderoonies commented Nov 28, 2021

Split user.preferences.fontSize into .editor and .console

Fixes #1953

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

TODO:

  • localization for font size settings
  • UI updates?

image

I think there probably doesn't need to be so much UI space spent on the two separate sections, and it might be possible to put both forms in the same section, but I didn't see precedence for that.

I was also not able to find the process for filling out localization when adding new labels and titles, let me know what needs to be done there!

@welcome
Copy link

welcome bot commented Nov 28, 2021

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@release-com
Copy link

release-com bot commented Nov 28, 2021

Release Environments

This pull request environment is provided by Release, learn more!
To see the status of the environment click on Environment Status below.

🔧Environment Status : https://app.releasehub.com/public/Processing%20Foundation/env-649cf05a5b

@anderoonies
[processing#1953] Separate Console and Editor font sizes
227477a 
    Split user.preferences.fontSize into .editor and .console
@anderoonies
Copy link
Author

anderoonies commented Nov 28, 2021

I just updated the tests for font size to use dispatch through the reduxRender function. Preferences isn't itself connected so I just patched setFontSize through, and the integration doesn't quite get to confirming that state is updating and that Preferences receives new props. I suppose Preferences itself could be connected and select the .preferences state, but I wanted to check in with someone about whether that would be worthwhile.

@anderoonies anderoonies force-pushed the split-console-and-editor-font-size branch from 26b6dad to 227477a Compare November 28, 2021 16:44
@raclim
Copy link
Collaborator

raclim commented Apr 19, 2023

Thank you so much for your efforts and for taking the time to contribute to this issue—I'm so sorry we couldn't get to your work in time! Since some time has passed I'm going to close this for now, but please feel free to reopen this or work on this again, thanks!

@raclim raclim closed this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Separate Console and Editor font sizes!

2 participants

@anderoonies @raclim