Feature/ added create-collection Button in Add to Collection #2924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for your work on this! I feel like the user experience laid out here might be a bit overwhelming to navigate due to the double modals, and would not be friendly to screen-readers. I think this issue might need a design first before getting implemented, so I'm going to close this PR for now. I'm sorry that we couldn't get this in, but please feel free to reopen a new one once a design for this is decided, or check out our other issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2505
Changes:
Added create-collection Button in Add to Collection
p5.js.Web.Editor._.Pastoral.quotation.-.Brave.2024-01-19.19-40-21.mp4
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123