Detect browser language to set default language for new users #3492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
SableRaf
reviewed
May 26, 2025
…idwivedi/p5.js-web-editor into feat/auto-detect-language
raclim
approved these changes
Jun 4, 2025
Collaborator
raclim
left a comment
raclim
left a comment
There was a problem hiding this comment.
I tested it out and this seems to look good to me! Thanks so much @deveshidwivedi for your work on this and @SableRaf for your review! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3490
Changes: This update improves the user experience for first-time visitors by automatically setting the app language based on their browser's language settings.
Previously, we didn’t have a utility that handled language detection. With this change, the app now checks the user's preferred language and picks the closest supported language available. If the user has already selected a language (like in their saved preferences), that choice is still respected.
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123