Refactor promises using async/await for apikey #2510
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @lindapaiste please consider the PR. |
Collaborator
|
We have a bunch of unit tests to make sure that we are getting the correct response. These tests are failing and showing that all of the errors are returning a 500 code instead of the appropriate code for each situation. We cannot consider this PR until it passes the tests. |
Collaborator
|
Since this isn't passing tests and some time has passed I'm going to close this PR for now. Please feel free to revisit this in the future or reopen a new one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes: #521
Changes:
Refactor the promises to async/await syntax for the apikey file.
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123