Skip to content

Conversation

@abhinav69217
Copy link

@abhinav69217 abhinav69217 commented Sep 16, 2023

Fixes #2358

Changes: Convert Searchbar to a function component

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #2358

@welcome
Copy link

welcome bot commented Sep 16, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@raclim raclim added the Area: Code Quality For refactoring, cleanup, or improvements to maintainability label Jan 26, 2024
@raclim
Copy link
Collaborator

raclim commented Mar 8, 2024

Thanks for submitting your work here!

I think one major change that I would make is destructuring the props that you're passing on line 8 so it could look like {searchTerm, resetSearchTerm, searchLabel, etc...}. Since this didn't pass a few tests and we have a couple other pull requests refactoring this component, I'm going to close this for now. However, please feel free to check out the other issues!

@raclim raclim closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Code Quality For refactoring, cleanup, or improvements to maintainability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert legacy React class components to function components

2 participants