Skip to content

Conversation

vivekbopaliya
Copy link
Contributor

Fixes #853

Changes:
Winston logging added.
All server console logs have been updated for development use only.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@vivekbopaliya
Copy link
Contributor Author

vivekbopaliya commented Dec 31, 2023

@lindapaiste please be aware that a few unnoticed errors might be slipping through undetected in current develop branch, allowing you to pass tests, that i just detected when i used logger.debug.

Screenshot (194)
Screenshot (195)

@lindapaiste lindapaiste added Area: Code Quality For refactoring, cleanup, or improvements to maintainability Area: Dependencies Pull requests that update a dependency file labels Jan 9, 2024
@raclim
Copy link
Collaborator

raclim commented Jun 24, 2024

Thanks so much for your work on this!

Due to some of the changes here falling out of date and some of the other features and fixes we'd like to prioritize at the moment (such as the privating sketches PR!), I'm going to close this pull request for now. I'm really sorry that we couldn't get this in at the moment, but please feel free to update and reopen this pull request in the future!

@raclim raclim closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Code Quality For refactoring, cleanup, or improvements to maintainability Area: Dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add logging with winston

3 participants