Skip to content

Fix : [#2909] Edit _sidebar.scss #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix : [#2909] Edit _sidebar.scss #2920

wants to merge 1 commit into from

Conversation

@Ri-Sharma
Copy link
Contributor

@Ri-Sharma Ri-Sharma commented Jan 17, 2024

Fixes #2909

Following Changes are made to '_sidebar.scss' file :-

  1. Added border radius of '10px' to Toggle file options & Sidebar Contract/Expand button.
  2. Changed width of Toggle file options svg.
  3. Removed Top/Bottom padding of Sidebar Header for alignment with Editor Header.
  4. Change font size of sidebar title.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@lindapaiste lindapaiste added Area: Design For UI/UX design updates, proposals, or feedback Area:CSS For styling or layout issues handled with CSS/SASS labels Jan 17, 2024
PiyushChandra17
PiyushChandra17 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@raclim
Copy link
Collaborator

raclim commented Mar 27, 2024

Closing this as explained in: #2909 (comment)!

@raclim raclim closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@PiyushChandra17 PiyushChandra17 PiyushChandra17 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area:CSS For styling or layout issues handled with CSS/SASS Area: Design For UI/UX design updates, proposals, or feedback

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adding rounded edges to Contract/Expand Sidebar button & aligning sidebar header with editor header.

4 participants

@Ri-Sharma @raclim @PiyushChandra17 @lindapaiste