Skip to content

src button a file icon for a seemless experience. #3363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

src button a file icon for a seemless experience. #3363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions client/modules/IDE/components/Editor/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ import * as hinter from '../../../../utils/p5-hinter';
import '../../../../utils/codemirror-search';

import beepUrl from '../../../../sounds/audioAlert.mp3';
import RightArrowIcon from '../../../../images/right-arrow.svg';
import LeftArrowIcon from '../../../../images/left-arrow.svg';
import { getHTMLFile } from '../../reducers/files';
import { selectActiveFile } from '../../selectors/files';

Expand Down Expand Up @@ -543,14 +541,20 @@ class Editor extends React.Component {
this.props.closeProjectOptions();
}}
>
<LeftArrowIcon focusable="false" aria-hidden="true" />
<IconButton
onClick={this.props.expandSidebar}
Copy link
Collaborator

@raclim raclim Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these lines (544-545) probably aren't needed here, since they're covered by the parent button element right above. If added, the IconButton implementation could probably look more something like: <IconButton focusable="false" aria-hidden="true" />

icon={FolderIcon}
/>{' '}
</button>
<button
aria-label={this.props.t('Editor.CloseSketchARIA')}
className="sidebar__expand"
onClick={this.props.expandSidebar}
>
<RightArrowIcon focusable="false" aria-hidden="true" />
<IconButton
onClick={this.props.expandSidebar}
icon={FolderIcon}
/>{' '}
</button>
<div className="editor__file-name">
<span>
Expand Down