Skip to content

Fixing use of placeholders inside i18n #3686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2025
Merged

Fixing use of placeholders inside i18n #3686

merged 2 commits into from
Oct 20, 2025

Conversation

cassiano
Copy link
Contributor

Fixes #3685

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

cassiano
cassiano commented Oct 15, 2025
View reviewed changes
translations/locales/uk-UA/translations.json
"EmptyCurrentPass": "Ви не ввели пароль.",
"IncorrectCurrentPass": "Поточний пароль неправильний",
"DefaultError":"Щось пішло не так",
"DefaultError": "Щось пішло не так",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were just (missing) blank spaces added by Prettier.

cassiano
cassiano commented Oct 15, 2025
View reviewed changes
translations/locales/uk-UA/translations.json
"AddonOnARIA": "так",
"AddonOffARIA": "ні",
"SoundReference": "Покликання на бібліотеку p5.sound, сумісну з p5.js $VERSION",
"SoundReference": "Покликання на бібліотеку p5.sound, сумісну з p5.js {{version}}",
Copy link
Contributor Author

@cassiano cassiano Oct 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you can see the relevant change itself.

raclim
raclim approved these changes Oct 20, 2025
View reviewed changes
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for catching these! This is definitely much more consistent, and I'm so glad the spacing is much more uniform!

@raclim raclim merged commit aa775de into processing:develop Oct 20, 2025
1 check passed
@cassiano cassiano deleted the fixing-use-of-placeholders-inside-i18n branch October 21, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raclim raclim raclim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fixing use of placeholders inside i18n

2 participants

@cassiano @raclim