Skip to content

[#3691] Add mobile visibility toggle to sketches dropdown #3697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[#3691] Add mobile visibility toggle to sketches dropdown #3697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions client/modules/IDE/components/SketchListRowBase.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,14 @@ const SketchListRowBase = ({
[changeVisibility]
);

const isPublic =
typeof sketch.visibility === 'string' &&
sketch.visibility.toLowerCase() === 'public';
const toggleVisibilityFromMenu = () => {
const toggle = isPublic ? 'Private' : 'Public';
handleVisibilityChange(sketch.id, sketch.name, toggle);
};

const userIsOwner = user.username === username;

let url = `/${username}/sketches/${sketch.id}`;
Expand Down Expand Up @@ -148,6 +156,14 @@ const SketchListRowBase = ({
<MenuItem hideIf={!user.authenticated} onClick={onAddToCollection}>
{t('SketchList.DropdownAddToCollection')}
</MenuItem>
<MenuItem
hideIf={!userIsOwner || !mobile}
onClick={toggleVisibilityFromMenu}
>
{isPublic
? t('SketchList.MakePrivate', 'Make Private')
: t('SketchList.MakePublic', 'Make Public')}
</MenuItem>
{/* <MenuItem onClick={handleSketchShare}>
{t('SketchList.DropdownShare')}
</MenuItem> */}
Expand Down