Skip to content

[p5.js KO] batch4_Shape - #287

Merged
Qianqianye merged 180 commits into
processing:mainfrom
yunyoungJang:yunyoungJang-patch-4
May 1, 2024
Merged

[p5.js KO] batch4_Shape#287
Qianqianye merged 180 commits into
processing:mainfrom
yunyoungJang:yunyoungJang-patch-4

Conversation

@yunyoungJang

Copy link
Copy Markdown
Contributor

Shape

@yunyoungJang yunyoungJang left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 테스트 (여지껏 제 코멘트가 안보이는지 모르고,,,,ㅠ)

file: src/core/shape/vertex.js
description: >
<p>Begins creating a hole within a flat shape.</p>
<p>평면 도형 내부에 구멍을 만들기 시작합니다.</p>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영 완료했습니다.

module: Shape
submodule: 3D Primitives
module: 도형
submodule: 3D 기초

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

도형에 가까워서 기초 도형을 사용하는 것은 어떻게 생각하시나요?

<p>Transformations such as <a href="/reference/p5/translate">translate()</a>,
<code>beginShape()</code> 와 <a href="/reference/p5/endShape">endShape()</a>사이에서는

<p><a href="/reference/p5/translate">translate()</a>,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 제가 잘 이해하지 못했는데요. ㅠㅠ혹시 구체적으로 서술해주실 수 있을까요?

file: src/core/shape/curves.js
description: >
<p>Calculates coordinates along a line that's tangent to a spline curve.</p>
<p>스플라인 곡선을 따라 탄젠트선 위의 좌표를 계산합니다.</p>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우선 접점으로 반영하겠습니다. 의견 주세요~~!


as in <code>curveTightness(1)</code>, connects the curve's points using
straight
<code>curveTightness(1)</code>처럼 타이트니스를 1로 설정하면,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우선 긴장도(tightness)로 반영하였습니다. 적절한 표현이라고 보여지는데 다른 의견이 있으시다면 주세요 ~!

Comment thread src/content/reference/ko/p5/freeGeometry.mdx Outdated

as in <code>curveTightness(1)</code>, connects the curve's points using
straight
<code>curveTightness(1)</code>처럼 타이트니스를 1로 설정하면,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

타이트하게는 -> 밀도 로 고쳤습니다.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵~


<p>The second and third parameters, <code>b</code> and <code>c</code>, are the
coordinates of the
<p>두 번째와 세 번째 매개변수, <code>b</code> <code>c</code>,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존 영어에 다 쉼표가 있어서 표기했는데 지워야할까요?!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

섭밋...테스트

@yinhwa yinhwa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Qianqianye @limzykenneth we're ready to merge this PR. Thank you :)

3차 리뷰 (9:00-11:50 중 쉬는 시간 30분 제외, 총 2시간 20분) 완료하였습니다.
미처 반영안된 리뷰들과 더불어, 모든 파일들에 걸쳐 단어, 문법, 문장 등 수정하였습니다. 이대로 승인처리하고 머지요청 드립니다 :) 모두 고생많으셨습니다! @yunyoungJang @designerSejinOH

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정규 벡터 -> 법선 벡터로 일괄 통일하겠습니다. (기존 문서에서 법선으로 번역한 것에 따라)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yinhwa @designerSejinOH 고생많으셨습니다. 감사합니다. 🙌

@Qianqianye
Qianqianye merged commit 6b28acc into processing:main May 1, 2024
@Qianqianye

Copy link
Copy Markdown
Collaborator

Looks great, thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants