Example not working correctly in textAlign() reference

[nikhilhvr]

Most appropriate sub-area of p5.js?

• Accessibility
• Color
• Core/Environment/Rendering
• Data
• DOM
• Events
• Image
• IO
• Math
• Typography
• Utilities
• WebGL
• Build Process
• Unit Testing
• Internalization
• Friendly Errors
• Other (specify if possible)

p5.js version

v1.5.0

Web browser and version

Microsoft Edge Version 110.0.1587.63 (Official build) (64-bit)

Operating System

Windows 10

Steps to reproduce this

Steps:

1. Go to this website https://p5js.org/reference/#/p5/textAlign
2. Need to Be Fixed:- The CENTER text not showing up in the center is not visible and the BOTTOM text is at the bottom.The CENTER and BOTTOM text are not visible.

Snippet:

textSize(16);
strokeWeight(0.5);

line(0, 12, width, 12);
textAlign(CENTER, TOP);
text('TOP', 0, 12, width);

line(0, 37, width, 37);
textAlign(CENTER);
text('CENTER', 0, 37, width);

line(0, 62, width, 62);
textAlign(CENTER, BASELINE);
text('BASELINE', 0, 62, width);

line(0, 87, width, 87);
textAlign(BOTTOM);
textAlign(CENTER);
text('BOTTOM', 0, 87, width);

describe(`The names of the four vertical alignments (TOP, CENTER, BASELINE,
  and BOTTOM) rendered each showing that alignment's placement relative to a
  horizontal line.`);

Currently

I am working on this Issue

[welcome]

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, please make sure to fill out the inputs in the issue forms. Thank you!

[nikhilhvr]

Can I work on this issue? @davepagurek @limzykenneth

[Qianqianye]

Hi @nikhilhvr, thanks for catching it. Yes, you can work on it. Before you get started, could you share how you are planning to rewrite the example code? Thanks!

[nikhilhvr]

Yeah, it is a syntax error that can be fixed.
textAlign(horizAlign, [vertAlign]).
The verAlign should be in square backets textAlign(CENTER, [CENTER]); & textAlign(CENTER, [BOTTOM]);

[davepagurek]

Hey @nikhilhvr, thanks for your interest in this issue! I believe this isn't a syntax issue -- in documentation, putting a parameter in square brackets is normally a way to indicate that it's optional, not that it must be passed in in square brackets. In your screenshot, for example, the CENTER text is placed below the line, where in p5 1.4.2, the line goes through the center of the text:

It looks like this will be fixed in this open PR #6060, so I believe we can close this issue once that PR has been merged.

[davepagurek]

I'm going to mark this as closed now that #6060 is in! Feel free to carry on the discussion if there's anything we've missed.