fixing chrome mobile 56 mousedown event fire issue #1820
Conversation
As describe on issue processing#1811 & processing#1815 Preventing google chrome mobile for firing duplicated mousePressed event when taping on element.
|
looks good |
| if(executeDefault === false) { | ||
| e.preventDefault(); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
This change causes problems with iOS (Safari). Specifically, once a sketch is created, it and the entire HTML page it is contained in will be unresponsive to actions that rely on ontouchend, such as link-clicking and button pushes. Commenting out the above else-branch makes everything work again.
I recommend that the above code is made conditional for the environment where it is needed (Chrome Mobile 56).
Meanwhile, I'm monkeypatching around the above 'fix'.
|
Thanks, I'll give it a try and report back. |
|
Ok, I updated the behavior of p5.js to only add duplicate firings if they are not already supported by the browser. Currently, chrome already fires off both mouse and touch events for a touch, firefox and safari do not. It is in the spec though, so we can expect that all browsers will eventually support this and the check for (window.PointerEvent) will be unnecessary. Here's more reading: The p5.js behavior has shifted slightly due to this. If you define a mouse related event (ie mousePressed, mouseMoved, etc), it will be triggered by either a mouse or a touch. It will trigger only once. However, if you define a touch related event (ie touchStarted, touchEnded, etc), it will be triggered by a touch, but not by a mouse click. In the past mouse and touch functions were completely interchangeable, now they go one direction. So if you are trying to define a function that will trigger on either mouse or touch, use the mouse named one. If you want to define a function that only triggers on touch, use the touch related ones. This preserves the functionality of select/option and any other elements that depend on the 'click' event. |
4 participants
As describe on issue #1811 & #1815
Preventing google chrome mobile for firing duplicated mousePressed event when taping on element.