p5.Camera Reorganization#3080
Merged
kjhollen merged 2 commits intoprocessing:webgl-gsoc-2018from Jul 11, 2018
Merged
Conversation
…hods to that object, and updates documentation throughout.
Member
|
Hey @AidanNelson this looks ready! Nice work with the rebase. There are some conflicts with the webgl-gsoc-2018 branch because it looks like some edits were made to camera.js since your starting point and also to p5.RendererGL.js. Do you want to have a go at fixing those? You can try to merge with webgl-gsoc-2018 locally and then pushing the code again. I'll merge this as-is once the conflicts are resolved, but it also feels like time to write some unit tests for p5.Camera as the next big step! |
Member
|
🎉 unit testing time! |
This was referenced Jul 11, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased p5.Camera Reorganization from #3063.
Updates:
_isActive()helper method to p5.Camera prototype, called before each update to the renderer in ortho(), perspective(), or camera() to support multiple cameras,return this;from constructor.