Add method for shadows #3154
Closed
Add method for shadows #3154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zalastax
approved these changes
Aug 16, 2018
Member
Zalastax
left a comment
Zalastax
left a comment
There was a problem hiding this comment.
Looks good!
Should we link to documentation about shadows?
https://github.com/processing/p5.js/wiki/p5.js-overview says that the shadow properties are not exposed as p5 methods. Do we need to update that?
Member
|
thanks @TanviKumar. new features should be discussed as issues first so people have a chance to weigh in on whether they should get added. then pull requests can be opened. in this case, I worry that this feature may be beyond the scope of p5 currently, but you're welcome to open an issue and see what everyone thinks. |
Member
Author
|
@lmmcart I'll go ahead and create an issue for this, hope the community approves! |
Member
|
great. I will close this for now while we discuss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.