Skip to content

Conversation

@unjust
Copy link
Contributor

@unjust unjust commented Nov 26, 2018

Reorder argument setting to bezier in 3d mode, so original arg values aren't overwritten.

In the code below:
https://github.com/processing/p5.js/blob/master/src/webgl/3d_primitives.js#L1088
x2 should = z1, but assigning y2 = x2 afterwards is basically assigning y2 = z1.

Demoing the bug:

screen shot 2018-11-26 at 10 12 09 am

Having a bezier with all z coords set to 0 should result in the same curve as a bezier with no z;

Like this (with changes from this branch):
screen shot 2018-11-26 at 10 09 13 am

@unjust unjust changed the title 3d rendered bezier curve args get overwritten 3d rendered bezier curve args get overwritten, fixes #3344 Nov 26, 2018
@unjust
Copy link
Contributor Author

unjust commented Nov 26, 2018

fixes issue #3344

@unjust
Copy link
Contributor Author

unjust commented Dec 26, 2018

@lmccart this should probably be fixed in the same way (using arguments) that was recommended earlier yes?

or is there a better way that will fit into the es6 transition?

@unjust
Copy link
Contributor Author

unjust commented Feb 21, 2019

@lmccart ping! what are the next steps on this?

@stalgiag stalgiag merged commit d80a86f into processing:master Apr 8, 2019
@stalgiag
Copy link
Contributor

stalgiag commented Apr 8, 2019

Sorry for letting this sit for so long. Thanks @unjust!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants