Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions .gitpod.Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
FROM gitpod/workspace-full-vnc

USER gitpod

RUN sudo apt-get update && \
sudo apt-get install -y \
ca-certificates \
fonts-liberation \
libappindicator3-1 \
libasound2 \
libatk-bridge2.0-0 \
libatk1.0-0 \
libc6 \
libcairo2 \
libcups2 \
libdbus-1-3 \
libexpat1 \
libfontconfig1 \
libgbm1 \
libgcc1 \
libglib2.0-0 \
libgtk-3-0 \
libnspr4 \
libnss3 \
libpango-1.0-0 \
libpangocairo-1.0-0 \
libstdc++6 \
libx11-6 \
libx11-xcb1 \
libxcb1 \
libxcomposite1 \
libxcursor1 \
libxdamage1 \
libxext6 \
libxfixes3 \
libxi6 \
libxrandr2 \
libxrender1 \
libxss1 \
libxtst6 \
lsb-release \
wget \
xdg-utils && \
sudo rm -rf /var/lib/apt/lists/*



RUN sudo apt-get -q update && \
sudo apt-get install -yq chromium-browser && \
sudo rm -rf /var/lib/apt/lists/*
16 changes: 16 additions & 0 deletions .gitpod.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
image:
file: .gitpod.Dockerfile
tasks:
- init: |
npm ci
gp sync-done boot
command: npm run grunt

- name: Dev
command: gp sync-await boot && sleep 10 && npm run dev

ports:
- port: 9001
onOpen: open-preview
- port: 5900
onOpen: ignore
5 changes: 3 additions & 2 deletions contributor_docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ We know the development process can be a little tricky at first. You're not alon

This process is also covered [in a video by The Coding Train.](https://youtu.be/Rr3vLyP1Ods) :train::rainbow:



1. Install [node.js](http://nodejs.org/), which also automatically installs the [npm](https://www.npmjs.org) package manager.

2. [Fork](https://help.github.com/articles/fork-a-repo) the [p5.js repository](https://github.com/processing/p5.js) into your own GitHub account.
Expand Down Expand Up @@ -113,6 +111,9 @@ This process is also covered [in a video by The Coding Train.](https://youtu.be/
9. Once everything is ready, submit your changes as a [pull request](https://help.github.com/articles/creating-a-pull-request).


Alternatively you can also use Gitpod for the one-click online setup for contributing with a single click it will launch a workspace and automatically clone the repo, install the dependencies run `npm run grunt` and `npm run dev`.

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)

# Gotchas

Expand Down
2 changes: 1 addition & 1 deletion tasks/test/mocha-chrome.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ module.exports = function(grunt) {
// Launch Chrome in headless mode
const browser = await puppeteer.launch({
headless: true,
args: ['--no-sandbox']
args: ['--no-sandbox', '--disable-setuid-sandbox']
Copy link
Author

@nisarhassan12 nisarhassan12 Nov 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for the test suite to work in Gitpod, this change has to be merged I have made a Pr to add the config files to the definitely-gp repo so no need to merge them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably fine to add but I would like to test this on a Linux machine before commiting it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for anyone coming here later, this change was added to main in e9f04db

});

try {
Expand Down