Skip to content

Conversation

@nbogie
Copy link
Contributor

@nbogie nbogie commented Nov 5, 2025

Resolves #8231

Changes:

  1. Added a find-replace in patch.mjs to substitute in the correct mouseButton type
mouseButton: { left: boolean; center: boolean; right: boolean };
  1. Added use of the new properties to test/types/basic.ts as regression test.

PR Checklist

  • npm run lint passes
  • [Inline reference] is included / updated. It's already correct for human readers.
  • [Unit tests] are included / updated. Yes. One visual test of fontWeight fails before and after my patch.

@nbogie
Copy link
Contributor Author

nbogie commented Nov 5, 2025

This perhaps temporary solution was suggested by Dave on discord

@nbogie
Copy link
Contributor Author

nbogie commented Nov 5, 2025

After build, I seedocs/parameterData.json has this unrelated addition, which I didn't commit as it's irrelevant to my change:

+    "contrast": {
+      "overloads": [
+        [
+          "Color"
+        ]
+      ]
+    },

@nbogie
Copy link
Contributor Author

nbogie commented Nov 5, 2025

@davepagurek thanks for the help - this look ok?

Copy link
Contributor

@davepagurek davepagurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@davepagurek davepagurek merged commit 0362c2c into processing:dev-2.0 Nov 5, 2025
2 checks passed
@processing processing deleted a comment from allcontributors bot Nov 5, 2025
@davepagurek
Copy link
Contributor

@all-contributors please add @nbogie for bug, code

@allcontributors
Copy link
Contributor

@davepagurek

We had trouble processing your request. Please try again later.

@davepagurek
Copy link
Contributor

@all-contributors please add @nbogie for bug, code

@allcontributors
Copy link
Contributor

@davepagurek

I've put up a pull request to add @nbogie! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants