Skip to content

Conversation

@reshma045
Copy link

Resolves #8215

Changes:

This PR updates the p5.Vector.setHeading() method to support only 2D vectors in alignment with the proposed 2.x design.

  • Added a dimension check in setHeading():
  • If the vector’s z component is nonzero (i.e., not 2D), the method now emits a clear p5._friendlyError() explaining that setHeading() is 2D-only in p5.js 2.x.
  • For 2D vectors (z === 0), heading behavior remains the same, preserving magnitude and rotating in the xy-plane.
  • Keeps compatibility with existing sketches that use setHeading() on true 2D vectors.

PR Checklist

Copy link
Collaborator

@perminder-17 perminder-17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @reshma045 , thanks for your work and time on this. This PR should target the dev-2.0 branch since the issue here is only with the 2.x versions. Can you please retarget your PR or open up a new PR on targetting dev-2.0 branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2.x] Fix dimensional quirk in the setHeading() method of p5.Vector

2 participants