added productive error when loop protection breaks in p5.strands

[kushal1061]

Resolves #8721

Changes:

• Added detection for loop-protection code (e.g. loopProtect / $OP.loopProtect) in user sketches before p5.strands transpilation.
• Loop protection breaks p5.strands shader compilation, an error is now thrown early with a clear message.
• The error instructs users to add // noprotect at the top of their sketch to disable loop protection.

Screenshots

Old error:

New error after changes:

PR Checklist

• npm run lint passes
• Inline reference is included / updated
• Unit tests are included / updated

[davepagurek]

Thanks @kushal1061, this is looking good! The one thing I'd ask before merging is if we can add unit tests to assert that it throws on OP-style and web editor style loop protection, so that we can make sure we don't accidentally break that in the future.

[p5-bot]

Continuous Release

CDN link

• https://raw.esm.sh/pr/p5@2ae31e8/lib/p5.min.js

Published Packages

• https://pkg.pr.new/p5@2ae31e8

Commit hash: 6c8cde7

Previous deployments

d9898f4

• https://raw.esm.sh/pr/p5@73e3a27/lib/p5.min.js
• https://pkg.pr.new/p5@73e3a27

---

This is an automated message.

[kushal1061]

Thanks @kushal1061, this is looking good! The one thing I'd ask before merging is if we can add unit tests to assert that it throws on OP-style and web editor style loop protection, so that we can make sure we don't accidentally break that in the future.

hi @davepagurek added unit test for both cases as you suggested

[davepagurek]

Thanks @kushal1061, looks great!

[davepagurek]

@all-contributors please add @kushal1061 for code